Fix order importer (#94)

-Log checkout form ID to allegro_orders_with_error table when checkout form does not exist

Co-authored-by: Maksymilian Strzyżewski <m.strzyzewski@macopedia.pl>

Author: mstrzyzewski

Model/AbstractOrderImporter.php

@@ -8,6 +8,7 @@
 use Macopedia\Allegro\Logger\Logger;
 use Macopedia\Allegro\Model\OrderImporter\Info;
 use Macopedia\Allegro\Model\OrderImporter\Processor;
+use Magento\Framework\Exception\NoSuchEntityException;
 
 abstract class AbstractOrderImporter
 {
@@ -53,7 +54,12 @@ public function __construct(
     protected function tryToProcessOrder($checkoutFormId)
     {
         try {
-            $checkoutForm = $this->checkoutFormRepository->get($checkoutFormId);
+            try {
+                $checkoutForm = $this->checkoutFormRepository->get($checkoutFormId);
+            } catch (Api\ClientException | NoSuchEntityException $e) {
+                $this->processor->addOrderWithErrorToTable($checkoutFormId, $e);
+                throw $e;
+            }
             if ($this->processor->validateCheckoutFormBoughtAtDate($checkoutForm)) {
                 $this->processor->processOrder($checkoutForm);
                 $this->successIds[] = $checkoutFormId;

Model/OrderImporter/Processor.php

@@ -92,16 +92,17 @@ public function __construct(
     public function processOrder(CheckoutFormInterface $checkoutForm): void
     {
         $connection = $this->resource->getConnection();
+        $checkoutFormId = $checkoutForm->getId();
         try {
             $connection->beginTransaction();
 
             if ($checkoutForm->getStatus() === Status::ALLEGRO_READY_FOR_PROCESSING) {
-                if (!$this->tryToGetOrder($checkoutForm->getId())) {
-                    $this->allegroReservation->compensateReservation($checkoutForm->getId());
+                if (!$this->tryToGetOrder($checkoutFormId)) {
+                    $this->allegroReservation->compensateReservation($checkoutFormId);
                     $this->tryCreateOrder($checkoutForm);
                 }
             } elseif ($checkoutForm->getStatus() === Status::ALLEGRO_CANCELLED) {
-                $this->allegroReservation->compensateReservation($checkoutForm->getId());
+                $this->allegroReservation->compensateReservation($checkoutFormId);
             } else {
                 $this->allegroReservation->placeReservation($checkoutForm);
             }
@@ -110,7 +111,7 @@ public function processOrder(CheckoutFormInterface $checkoutForm): void
             $connection->commit();
         } catch (\Exception $e) {
             $connection->rollBack();
-            $this->addOrderWithErrorToTable($checkoutForm, $e);
+            $this->addOrderWithErrorToTable($checkoutFormId, $e);
             throw $e;
         }
     }
@@ -129,14 +130,12 @@ protected function tryToGetOrder($id): ?OrderInterface
     }
 
     /**
-     * @param CheckoutFormInterface $checkoutForm
+     * @param string $checkoutFormId
      * @param \Exception $e
-     * @throws \Exception
+     * @throws OrderProcessingException
      */
-    private function addOrderWithErrorToTable(CheckoutFormInterface $checkoutForm, \Exception $e): void
+    public function addOrderWithErrorToTable(string $checkoutFormId, \Exception $e): void
     {
-        $checkoutFormId = $checkoutForm->getId();
-
         $date = $this->date->gmtDate();
 
         try {