Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 09fd927

Browse files
committed
Revert "MessageComposerButtons: don't hide moreButtons behind dropdown in wide mode"
This reverts commit 5fd0906.
1 parent c2b5597 commit 09fd927

File tree

2 files changed

+32
-14
lines changed

2 files changed

+32
-14
lines changed

src/components/views/rooms/MessageComposerButtons.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,11 @@ const MessageComposerButtons: React.FC<IProps> = (props: IProps) => {
103103

104104
return <UploadButtonContextProvider roomId={roomId} relation={props.relation}>
105105
{ mainButtons }
106-
{ moreButtons.length > 0 &&
107-
(narrow ?
108-
<AccessibleTooltipButton
109-
className={moreOptionsClasses}
110-
onClick={props.toggleButtonMenu}
111-
title={_t("More options")}
112-
/> : moreButtons
113-
)
114-
}
106+
{ moreButtons.length > 0 && <AccessibleTooltipButton
107+
className={moreOptionsClasses}
108+
onClick={props.toggleButtonMenu}
109+
title={_t("More options")}
110+
/> }
115111
{ props.isMenuOpen && (
116112
<IconizedContextMenu
117113
onFinished={props.toggleButtonMenu}

test/components/views/rooms/MessageComposerButtons-test.tsx

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const mockProps: React.ComponentProps<typeof MessageComposerButtons> = {
4040
};
4141

4242
describe("MessageComposerButtons", () => {
43-
it("Renders all buttons in wide mode", () => {
43+
it("Renders emoji and upload buttons in wide mode", () => {
4444
const buttons = wrapAndRender(
4545
<MessageComposerButtons
4646
isMenuOpen={false}
@@ -55,10 +55,32 @@ describe("MessageComposerButtons", () => {
5555
expect(buttonLabels(buttons)).toEqual([
5656
"Emoji",
5757
"Attachment",
58-
"Sticker",
59-
"Voice Message",
60-
"Poll",
61-
"Location",
58+
"More options",
59+
]);
60+
});
61+
62+
it("Renders other buttons in menu in wide mode", () => {
63+
const buttons = wrapAndRender(
64+
<MessageComposerButtons
65+
isMenuOpen={true}
66+
showLocationButton={true}
67+
showPollsButton={true}
68+
showStickersButton={true}
69+
{...mockProps}
70+
/>,
71+
false,
72+
);
73+
74+
expect(buttonLabels(buttons)).toEqual([
75+
"Emoji",
76+
"Attachment",
77+
"More options",
78+
[
79+
"Sticker",
80+
"Voice Message",
81+
"Poll",
82+
"Location",
83+
],
6284
]);
6385
});
6486

0 commit comments

Comments
 (0)