fixed errors

Author: mcosovic

.github/workflows/Build.yml

@@ -9,7 +9,7 @@ jobs:
       matrix:
         julia-version: ['1.6.1']
         julia-arch: [x64]
-        os: [windows-latest]
+        os: [ubuntu-latest, windows-latest, macOS-latest]
         exclude:
           - os: macOS-latest
             julia-arch: x86

src/graphicalmodel.jl

@@ -408,8 +408,8 @@ function graphicalModelTree(system, virtualMean, virtualVariance, root)
             row = system.jacobian.rowval[i]
             NvariableInRow = system.jacobianTranspose.colptr[row + 1] - system.jacobianTranspose.colptr[row]
             if NvariableInRow == 1
-                meanDirect[col] += z[row] * system.jacobian[row, col] / v[row]
-                weightDirect[col] += system.jacobian[row, col]^2 / v[row]
+                meanDirect[col] += system.observation[row] * system.jacobian[row, col] / system.variance[row]
+                weightDirect[col] += system.jacobian[row, col]^2 / system.variance[row]
             else
                 push!(colForward[col], row)
                 push!(colBackward[col], row)

src/inferencetree.jl

@@ -38,7 +38,7 @@ function forwardFactorVariable(gbp::GraphicalModelTree)
         gbp.inference.fromFactor[gbp.graph.passFactorVariable] = factor
         gbp.inference.toVariable[gbp.graph.passFactorVariable] = variable
 
-        Mrow = z[factor]; Vrow = v[factor]
+        Mrow = gbp.system.observation[factor]; Vrow = gbp.system.variance[factor]
         for j in gbp.graph.incomingToFactor[factor]
             coeff = gbp.system.jacobian[gbp.inference.toFactor[j], gbp.inference.fromVariable[j]]
             Mrow -= coeff * gbp.inference.meanVariableFactor[j]
@@ -105,7 +105,7 @@ function backwardFactorVariable(gbp::GraphicalModelTree)
             gbp.inference.fromFactor[gbp.graph.passFactorVariable] = factor
             gbp.inference.toVariable[gbp.graph.passFactorVariable] = variable
 
-            Mrow = z[factor]; Vrow = v[factor]
+            Mrow = gbp.system.observation[factor]; Vrow = gbp.system.variance[factor]
             for j in gbp.graph.incomingToFactor[factor]
                 if gbp.inference.fromVariable[j] != variable
                     coeff = gbp.system.jacobian[factor, gbp.inference.fromVariable[j]]