Skip to content

Commit 6c8d2e4

Browse files
committed
fix small errors
1 parent 1692ca9 commit 6c8d2e4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "FactorGraph"
22
uuid = "528f6532-2a0d-4856-bb42-8bcefd89a10f"
33
authors = ["Mirsad Cosovic <mirsad.cosovic@gmail.com>"]
4-
version = "0.1.2"
4+
version = "0.1.3"
55

66
[deps]
77
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"

src/utility.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function errorMetric(gbp::Union{ContinuousModel, ContinuousTreeModel})
2828
@inbounds for i = 1:length(gbp.system.observation)
2929
rmse += (gbp.system.observation[i] - observationGBP[i])^2
3030
mae += abs(gbp.system.observation[i] - observationGBP[i])
31-
wrss += (gbp.system.observation[i] - observationGBP[i]) / gbp.system.variance[i]
31+
wrss += (gbp.system.observation[i] - observationGBP[i])^2 / gbp.system.variance[i]
3232
end
3333
rmse = (rmse / NactiveRows)^(1/2)
3434
mae = mae / NactiveRows
@@ -45,7 +45,7 @@ end
4545
@inbounds for i = 1:length(gbp.system.observation)
4646
rmse += (gbp.system.observation[i] - observationGBP[i])^2
4747
mae += abs(gbp.system.observation[i] - observationGBP[i])
48-
wrss += (gbp.system.observation[i] - observationGBP[i]) / gbp.system.variance[i]
48+
wrss += (gbp.system.observation[i] - observationGBP[i])^2 / gbp.system.variance[i]
4949
end
5050
rmse = (rmse / NactiveRows)^(1/2)
5151
mae = mae / NactiveRows
@@ -76,7 +76,7 @@ function wls(gbp::Union{ContinuousModel, ContinuousTreeModel})
7676
@inbounds for i = 1:length(gbp.system.observation)
7777
rmse += (gbp.system.observation[i] - observationWLS[i])^2
7878
mae += abs(gbp.system.observation[i] - observationWLS[i])
79-
wrss += (gbp.system.observation[i] - observationWLS[i]) / gbp.system.variance[i]
79+
wrss += (gbp.system.observation[i] - observationWLS[i])^2 / gbp.system.variance[i]
8080
end
8181
rmse = (rmse / NactiveRows)^(1/2)
8282
mae = mae / NactiveRows

0 commit comments

Comments
 (0)