Fix improperly placed label "error" in the exposed metrics

mgumz · mgumz · commit 61e7b738b811 · 2025-02-26T19:19:15.000+01:00
mtr_runs_total{... tests="10",tos="0"error=""} 1 1740573735014

Fixes GH#32
diff --git a/pkg/job/prometheus.go b/pkg/job/prometheus.go
@@ -69,7 +69,7 @@ func (c *Collector) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 		for k, v := range job.Runs {
 			fmt.Fprintf(w, "mtr_runs_total{%s%s} %d %d\n",
-				l, fmt.Sprintf("error=%q", k), v, tsMs)
+				l, fmt.Sprintf(",error=%q", k), v, tsMs)
 		}
 
 		fmt.Fprintf(w, "mtr_report_duration_seconds{%s} %f %d\n",

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ func (c Collector) ServeHTTP(w http.ResponseWriter, r http.Request) {`
`69`	`69`
`70`	`70`	`for k, v := range job.Runs {`
`71`	`71`	`fmt.Fprintf(w, "mtr_runs_total{%s%s} %d %d\n",`
`72`		`- l, fmt.Sprintf("error=%q", k), v, tsMs)`
	`72`	`+ l, fmt.Sprintf(",error=%q", k), v, tsMs)`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`fmt.Fprintf(w, "mtr_report_duration_seconds{%s} %f %d\n",`