Skip to content

Commit 6497600

Browse files
authored
Merge pull request #1733 from microbiomedata/issue-1731-executn-resource-nullable
Make `execution_resource` nullable
2 parents f303e27 + 4ca027a commit 6497600

File tree

4 files changed

+103
-3
lines changed

4 files changed

+103
-3
lines changed
Lines changed: 100 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,100 @@
1+
"""Make execution_resource nullable.
2+
3+
Revision ID: 43fc92514a16
4+
Revises: 09a705b0bc00
5+
Create Date: 2025-08-12 18:10:18.144086
6+
7+
"""
8+
9+
from typing import Optional
10+
11+
import sqlalchemy as sa
12+
from alembic import op
13+
14+
# revision identifiers, used by Alembic.
15+
revision: str = "43fc92514a16"
16+
down_revision: Optional[str] = "09a705b0bc00"
17+
branch_labels: Optional[str] = None
18+
depends_on: Optional[str] = None
19+
20+
21+
def upgrade():
22+
# ### commands auto generated by Alembic - please adjust! ###
23+
op.alter_column(
24+
"mags_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
25+
)
26+
op.alter_column(
27+
"metabolomics_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
28+
)
29+
op.alter_column(
30+
"metagenome_annotation", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
31+
)
32+
op.alter_column(
33+
"metagenome_assembly", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
34+
)
35+
op.alter_column(
36+
"metaproteomic_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
37+
)
38+
op.alter_column(
39+
"metatranscriptome", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
40+
)
41+
op.alter_column(
42+
"metatranscriptome_annotation",
43+
"execution_resource",
44+
existing_type=sa.VARCHAR(),
45+
nullable=True,
46+
)
47+
op.alter_column(
48+
"metatranscriptome_assembly",
49+
"execution_resource",
50+
existing_type=sa.VARCHAR(),
51+
nullable=True,
52+
)
53+
op.alter_column("nom_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=True)
54+
op.alter_column(
55+
"read_based_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=True
56+
)
57+
op.alter_column("reads_qc", "execution_resource", existing_type=sa.VARCHAR(), nullable=True)
58+
# ### end Alembic commands ###
59+
60+
61+
def downgrade():
62+
# ### commands auto generated by Alembic - please adjust! ###
63+
op.alter_column("reads_qc", "execution_resource", existing_type=sa.VARCHAR(), nullable=False)
64+
op.alter_column(
65+
"read_based_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
66+
)
67+
op.alter_column(
68+
"nom_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
69+
)
70+
op.alter_column(
71+
"metatranscriptome_assembly",
72+
"execution_resource",
73+
existing_type=sa.VARCHAR(),
74+
nullable=False,
75+
)
76+
op.alter_column(
77+
"metatranscriptome_annotation",
78+
"execution_resource",
79+
existing_type=sa.VARCHAR(),
80+
nullable=False,
81+
)
82+
op.alter_column(
83+
"metatranscriptome", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
84+
)
85+
op.alter_column(
86+
"metaproteomic_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
87+
)
88+
op.alter_column(
89+
"metagenome_assembly", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
90+
)
91+
op.alter_column(
92+
"metagenome_annotation", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
93+
)
94+
op.alter_column(
95+
"metabolomics_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
96+
)
97+
op.alter_column(
98+
"mags_analysis", "execution_resource", existing_type=sa.VARCHAR(), nullable=False
99+
)
100+
# ### end Alembic commands ###

nmdc_server/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ class PipelineStep:
448448
git_url = Column(String, nullable=False)
449449
started_at_time = Column(DateTime, nullable=False)
450450
ended_at_time = Column(DateTime)
451-
execution_resource = Column(String, nullable=False)
451+
execution_resource = Column(String, nullable=True)
452452

453453
has_inputs = association_proxy("inputs", "id")
454454
has_outputs = association_proxy("outputs", "id")

nmdc_server/schemas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ class PipelineStepBase(BaseModel):
428428
git_url: str
429429
started_at_time: DateType
430430
ended_at_time: Optional[DateType] = None
431-
execution_resource: str
431+
execution_resource: Optional[str] = None
432432

433433

434434
class PipelineStep(PipelineStepBase):

web/src/data/api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export interface DerivedDataResult extends BaseSearchResult {
101101
git_url: string;
102102
started_at_time: string;
103103
ended_at_time: string;
104-
execution_resource: string;
104+
execution_resource: string | null;
105105
was_informed_by: OmicsProcessingBaseResult[];
106106
outputs: DataObjectSearchResult[];
107107
}

0 commit comments

Comments
 (0)