Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 13092ee

Browse files
author
Bret Johnson
authored
Updated add colloborator message to make clear that it sends an invite (#470)
email, not adding the collaborator immediately. Also made a few unit test fixes.
1 parent 0d19214 commit 13092ee

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cli/script/command-executor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ function addCollaborator(command: cli.ICollaboratorAddCommand): Promise<void> {
263263

264264
return sdk.addCollaborator(command.appName, command.email)
265265
.then((): void => {
266-
log("Successfully added \"" + command.email + "\" as a collaborator to the app \"" + command.appName + "\".");
266+
log("Collaborator invitation email for \"" + command.appName + "\" sent to \"" + command.email + "\".");
267267
});
268268
}
269269

cli/test/cli.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -475,9 +475,9 @@ describe("CLI", () => {
475475
cmdexec.execute(command)
476476
.done((): void => {
477477
sinon.assert.calledOnce(addApp);
478-
sinon.assert.calledOnce(log);
479-
sinon.assert.calledWithExactly(log, "Successfully added the \"a\" app.\nUse \"code-push deployment add\" to add deployment(s) to the app.");
480-
//sinon.assert.calledOnce(deploymentList);
478+
sinon.assert.calledTwice(log);
479+
sinon.assert.calledWithExactly(log, "Successfully added the \"a\" app, along with the following default deployments:");
480+
sinon.assert.calledOnce(deploymentList);
481481
done();
482482
});
483483
});
@@ -612,7 +612,7 @@ describe("CLI", () => {
612612
.done((): void => {
613613
sinon.assert.calledOnce(addCollaborator);
614614
sinon.assert.calledOnce(log);
615-
sinon.assert.calledWithExactly(log, "Successfully added \"b@b.com\" as a collaborator to the app \"a\".");
615+
sinon.assert.calledWithExactly(log, "Collaborator invitation email for \"a\" sent to \"b@b.com\".");
616616

617617
done();
618618
});
@@ -1394,7 +1394,7 @@ describe("CLI", () => {
13941394
done(new Error("Did not throw error."));
13951395
})
13961396
.catch((err) => {
1397-
assert.equal(err.message, "Platform must be either \"android\", \"ios\" or \"windows\".");
1397+
assert.equal(err.message, "Platform must be \"android\", \"ios\", or \"windows\".");
13981398
sinon.assert.notCalled(release);
13991399
sinon.assert.notCalled(spawn);
14001400
done();

0 commit comments

Comments
 (0)