Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 9204133

Browse files
Fix typo and refactor code
1 parent 05fb0d4 commit 9204133

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

src/script/acquisition-sdk.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,15 @@ export class AcquisitionStatus {
5858
}
5959

6060
export class AcquisitionManager {
61-
private readonly BASER_URL_PART = "appcenter.ms";
61+
private readonly BASE_URL_PART = "appcenter.ms";
6262
private _appVersion: string;
6363
private _clientUniqueId: string;
6464
private _deploymentKey: string;
6565
private _httpRequester: Http.Requester;
6666
private _ignoreAppVersion: boolean;
6767
private _serverUrl: string;
6868
private _publicPrefixUrl: string = "v0.1/public/codepush/";
69-
69+
private _statusCode: number;
7070
private static _apiCallsDisabled: boolean = false;
7171
constructor(httpRequester: Http.Requester, configuration: Configuration) {
7272
this._httpRequester = httpRequester;
@@ -82,9 +82,10 @@ export class AcquisitionManager {
8282
this._ignoreAppVersion = configuration.ignoreAppVersion;
8383
}
8484

85+
private isRecoverable = (statusCode: number): boolean => statusCode >= 500 || statusCode === 408 || statusCode === 429;
8586

86-
private handleRequestFailure(statusCode: number) {
87-
if (this._serverUrl.includes(this.BASER_URL_PART) && !(statusCode >= 500 || statusCode == 408 || statusCode == 429)) {
87+
private handleRequestFailure() {
88+
if (this._serverUrl.includes(this.BASE_URL_PART) && !this.isRecoverable(this._statusCode)) {
8889
AcquisitionManager._apiCallsDisabled = true;
8990
}
9091
}
@@ -119,7 +120,8 @@ export class AcquisitionManager {
119120

120121
if (response.statusCode !== 200) {
121122
let errorMessage: any;
122-
this.handleRequestFailure(response.statusCode)
123+
this._statusCode = response.statusCode;
124+
this.handleRequestFailure();
123125
if (response.statusCode === 0) {
124126
errorMessage = `Couldn't send request to ${requestUrl}, xhr.statusCode = 0 was returned. One of the possible reasons for that might be connection problems. Please, check your internet connection.`;
125127
} else {
@@ -219,7 +221,8 @@ export class AcquisitionManager {
219221
}
220222

221223
if (response.statusCode !== 200) {
222-
this.handleRequestFailure(response.statusCode)
224+
this._statusCode = response.statusCode;
225+
this.handleRequestFailure();
223226
callback(new CodePushHttpError(response.statusCode + ": " + response.body), /*not used*/ null);
224227
return;
225228
}
@@ -251,7 +254,8 @@ export class AcquisitionManager {
251254
}
252255

253256
if (response.statusCode !== 200) {
254-
this.handleRequestFailure(response.statusCode)
257+
this._statusCode = response.statusCode;
258+
this.handleRequestFailure();
255259
callback(new CodePushHttpError(response.statusCode + ": " + response.body), /*not used*/ null);
256260
return;
257261
}

0 commit comments

Comments
 (0)