Skip to content

Commit f3419a1

Browse files
committed
remove rnVersion
1 parent 2cfca0d commit f3419a1

File tree

3 files changed

+9
-19
lines changed

3 files changed

+9
-19
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,19 @@ jobs:
3030
strategy:
3131
fail-fast: false
3232
matrix:
33-
rnwVersion: [ 'latest', 'v0.74-stable', 'v0.72-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.75
34-
rnVersion: [ 'latest', '0.74-stable', '0.72-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.75
33+
rnwVersion: [ 'latest', '0.74-stable', '0.72-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.75
3534
useRnwNuGet: [false, true] # test building with both RNW source and RNW NuGet
3635
include:
3736
- rnwVersion: 'latest'
38-
rnVersion: 'latest'
3937
rnTemplate: 'react-native@latest'
40-
- rnwVersion: 'v0.74-stable'
41-
rnVersion: '0.74-stable'
38+
- rnwVersion: '0.74-stable'
4239
rnTemplate: 'react-native@0.74-stable'
43-
- rnwVersion: 'v0.72-stable'
44-
rnVersion: '0.72-stable'
40+
- rnwVersion: '0.72-stable'
4541
rnTemplate: 'react-native@0.72-stable'
4642
uses: ./.github/workflows/template-testcli.yml
4743
with:
4844
vmImage: windows-2022
4945
rnwVersion: ${{ matrix.rnwVersion }}
50-
rnVersion: ${{ matrix.rnVersion }}
5146
useRnwNuGet: ${{ matrix.useRnwNuGet }}
5247
rnTemplate: ${{ matrix.rnTemplate }}
5348

.github/workflows/pr.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,24 +42,19 @@ jobs:
4242
strategy:
4343
fail-fast: false
4444
matrix:
45-
rnwVersion: [ 'latest', 'v0.74-stable', 'v0.72-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.75
46-
rnVersion: [ 'latest', '0.74-stable', '0.72-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.75
45+
rnwVersion: [ 'latest', '0.74-stable', '0.72-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.75
4746
useRnwNuGet: [false, true] # test building with both RNW source and RNW NuGet
4847
include:
4948
- rnwVersion: 'latest'
50-
rnVersion: 'latest'
5149
rnTemplate: 'react-native@latest'
52-
- rnwVersion: 'v0.74-stable'
53-
rnVersion: '0.74-stable'
50+
- rnwVersion: '0.74-stable'
5451
rnTemplate: 'react-native@0.74-stable'
55-
- rnwVersion: 'v0.72-stable'
56-
rnVersion: '0.72-stable'
52+
- rnwVersion: '0.72-stable'
5753
rnTemplate: 'react-native@0.72-stable'
5854
uses: ./.github/workflows/template-testcli.yml
5955
with:
6056
vmImage: windows-2022
6157
rnwVersion: ${{ matrix.rnwVersion }}
62-
rnVersion: ${{ matrix.rnVersion }}
6358
useRnwNuGet: ${{ matrix.useRnwNuGet }}
6459
rnTemplate: ${{ matrix.rnTemplate }}
6560

.github/workflows/template-testcli.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ jobs:
4141
run: yarn link
4242
working-directory: package
4343

44-
- name: create react-native@${{ inputs.rnVersion }} app
45-
run: npx --yes @react-native-community/cli@latest init testrnx --version ${{ inputs.rnVersion }} --skip-install --install-pods false --verbose --skip-git-init true
44+
- name: create react-native@${{ inputs.rnwVersion }} app
45+
run: npx --yes @react-native-community/cli@latest init testrnx --version ${{ inputs.rnwVersion }} --skip-install --install-pods false --verbose --skip-git-init true
4646
working-directory: ../
4747

4848
- name: yarn add react-native-windows
49-
run: yarn add react-native-windows@${{ inputs.rnwVersion }}
49+
run: yarn add react-native-windows@v${{ inputs.rnwVersion }}
5050
working-directory: ../testrnx
5151

5252
- name: yarn

0 commit comments

Comments
 (0)