fix simsurv bug

RaphaelS1 · RaphaelS1 · commit 08e9d2b707ac · 2022-02-01T07:53:13.000Z
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: mlr3proba
 Title: Probabilistic Supervised Learning for 'mlr3'
-Version: 0.4.3
+Version: 0.4.3.9000
 Authors@R:
     c(person(given = "Raphael",
              family = "Sonabend",
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# mlr3proba 0.4.3.9000
+
+* Fixed bug in `simsurv` task that made it impossible to predict the target
+
 # mlr3proba 0.4.3
 
 * Massive speed-up in distrcompositor PipeOp/pipeline
diff --git a/R/TaskGeneratorSimsurv.R b/R/TaskGeneratorSimsurv.R
@@ -55,7 +55,7 @@ TaskGeneratorSimsurv = R6Class("TaskGeneratorSimsurv",
       )
       betas = c(treatment = -0.5, height = 1, weight = 0)
 
-      data = setDT(invoke(simsurv::simsurv, x = covs, betas = , .args = pv)) # nolint
+      data = setDT(invoke(simsurv::simsurv, x = covs, betas = betas, .args = pv)) # nolint
       data = rcbind(data, covs)
       TaskSurv$new("simsurv", remove_named(data, "id"), time = "eventtime", event = "status")
     }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ TaskGeneratorSimsurv = R6Class("TaskGeneratorSimsurv",`
`55`	`55`	`)`
`56`	`56`	`betas = c(treatment = -0.5, height = 1, weight = 0)`
`57`	`57`
`58`		`- data = setDT(invoke(simsurv::simsurv, x = covs, betas = , .args = pv)) # nolint`
	`58`	`+ data = setDT(invoke(simsurv::simsurv, x = covs, betas = betas, .args = pv)) # nolint`
`59`	`59`	`data = rcbind(data, covs)`
`60`	`60`	`TaskSurv$new("simsurv", remove_named(data, "id"), time = "eventtime", event = "status")`
`61`	`61`	`}`