Skip to content

Commit 4d65f00

Browse files
committed
refactor: use if statement instead of ifelse where scalar is used
1 parent 8008f9c commit 4d65f00

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

R/LearnerDensKDE.R

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,12 @@ LearnerDensKDE = R6::R6Class("LearnerDensKDE",
5454
ClassName)))$new()
5555

5656

57-
bw = ifelse(self$param_set$values$bandwidth == "silver",
57+
bw = if (isTRUE(self$param_set$values$bandwidth == "silver")) {
58+
"silver"
59+
} else {
5860
0.9 * min(sd(data), stats::IQR(data, na.rm = TRUE) / 1.349, na.rm = TRUE) *
59-
length(data)^-0.2,
60-
self$param_set$values$bandwidth)
61+
length(data)^-0.2
62+
}
6163

6264
pdf = function(x) {} # nolint
6365

R/PipeOpTaskSurvRegr.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ PipeOpTaskSurvRegr = R6Class("PipeOpTaskSurvRegr",
201201
reorder = private$.reorder(backend, pv$features, pv$target, inputs[[2]])
202202
)
203203

204-
target = ifelse(method == "reorder", pv$target, time)
204+
target = if (method == "reorder") pv$target else time
205205

206206
new_task = TaskRegr$new(id = input$id, backend = backend, target = target)
207207

R/pecs.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ pecs.list = function(x, measure = c("graf", "logloss"), times, n, eps = NULL, ta
7676
measure = match.arg(measure)
7777

7878
if (is.null(eps)) {
79-
eps = ifelse(measure == "graf", 1e-3, 1e-15)
79+
eps = if (measure == "graf") 1e-3 else 1e-15
8080
} else {
8181
assertNumeric(eps, lower = -1, upper = 1)
8282
}
@@ -148,7 +148,7 @@ pecs.PredictionSurv = function(x, measure = c("graf", "logloss"), times, n, eps
148148

149149
measure = match.arg(measure)
150150
if (is.null(eps)) {
151-
eps = ifelse(measure == "graf", 1e-3, 1e-15)
151+
eps = if (measure == "graf") 1e-3 else 1e-15
152152
} else {
153153
assertNumeric(eps, lower = -1, upper = 1)
154154
}

0 commit comments

Comments
 (0)