rubocop appeasement

Author: jamis

.rubocop.yml

@@ -64,7 +64,7 @@ Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
 
 Metrics/ClassLength:
-  Max: 200
+  Enabled: false
 
 Metrics/ModuleLength:
   Enabled: false

lib/mongoid/association/embedded/embeds_many/proxy.rb

@@ -443,34 +443,46 @@ def append(document)
             execute_callback :after_add, document
           end
 
+          # Returns a unique id for the document, which is either
+          # its _id or its object_id.
+          def id_of(doc)
+            doc._id || doc.object_id
+          end
+
           # Optimized version of #append that handles multiple documents
           # in a more efficient way.
           def append_many(documents, &block)
-            id_of = ->(doc){ doc._id || doc.object_id }
+            visited_docs = Set.new(_target.map { |doc| id_of(doc) })
+            unique_set = get_unique_new_docs(documents, visited_docs, &block)
+
+            _unscoped.concat(unique_set)
+            _target.push(*scope(unique_set))
+            update_attributes_hash
+
+            unique_set.each { |doc| execute_callback :after_add, doc }
+          end
 
-            visited_docs = Set.new(_target.map(&id_of))
+          # Return a list of unique new documents that do not yet exist
+          # in the association, and which have not previously been seen.
+          def get_unique_new_docs(documents, visited_docs, &block)
             next_index = _unscoped.size
 
-            unique_set = documents.select do |doc|
+            documents.select do |doc|
               next unless doc
-              next if visited_docs.include?(id_of[doc])
+
+              id = id_of(doc)
+              next if visited_docs.include?(id)
 
               execute_callback :before_add, doc
 
-              visited_docs.add(id_of[doc])
+              visited_docs.add(id)
               integrate(doc)
 
               doc._index = next_index
               next_index += 1
 
-              block.call(doc) if block
+              block&.call(doc)
             end
-
-            _unscoped.concat(unique_set)
-            _target.push(*scope(unique_set))
-            update_attributes_hash
-
-            unique_set.each { |doc| execute_callback :after_add, doc }
           end
 
           # Instantiate the binding associated with this association.

lib/mongoid/association/referenced/has_many/proxy.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-# TODO: consider refactoring this Proxy class, to satisfy the following
-# cops...
-# rubocop:disable Metrics/ClassLength
 module Mongoid
   module Association
     module Referenced
@@ -588,4 +585,3 @@ def save_or_delay(doc, docs, inserts)
     end
   end
 end
-# rubocop:enable Metrics/ClassLength