improve the name of the extracted method

Author: jamis

lib/mongoid/association/embedded/embeds_many/proxy.rb

@@ -451,19 +451,38 @@ def id_of(doc)
 
           # Optimized version of #append that handles multiple documents
           # in a more efficient way.
+          #
+          # @param [ Array<Document> ] documents The documents to append.
+          #
+          # @return [ EmbedsMany::Proxy ] This proxy instance.
           def append_many(documents, &block)
-            unique_set = get_unique_new_docs(documents, &block)
+            unique_set = process_incoming_docs(documents, &block)
 
             _unscoped.concat(unique_set)
             _target.push(*scope(unique_set))
             update_attributes_hash
 
             unique_set.each { |doc| execute_callback :after_add, doc }
+
+            self
           end
 
-          # Return a list of unique new documents that do not yet exist
-          # in the association.
-          def get_unique_new_docs(documents, &block)
+          # Processes the list of documents, building a list of those
+          # that are not already in the association, and preparing
+          # each unique document to be integrated into the association.
+          #
+          # The :before_add callback is executed for each unique document
+          # as part of this step.
+          #
+          # @param [ Array<Document> ] documents The incoming documents to
+          #   process.
+          #
+          # @yield [ Document ] Optional block to call for each unique
+          #   document.
+          #
+          # @return [ Array<Document> ] The list of unique documents that
+          #   do not yet exist in the association.
+          def process_incoming_docs(documents, &block)
             visited_docs = Set.new(_target.map { |doc| id_of(doc) })
             next_index = _unscoped.size
 
@@ -481,7 +500,7 @@ def get_unique_new_docs(documents, &block)
               doc._index = next_index
               next_index += 1
 
-              block&.call(doc)
+              block&.call(doc) || true
             end
           end