Protection against my own habit to forget to pass a callback.

Author: moonpyk

lib/ntp-client.js

@@ -13,7 +13,7 @@
 
     exports.defaultNtpPort = 123;
     exports.defaultNtpServer = "pool.ntp.org";
-    
+
     /**
      * Amount of acceptable time to await for a response from the remote server.
      * Configured default to 10 seconds.
@@ -24,10 +24,17 @@
      * Fetches the current NTP Time from the given server and port.
      * @param {string} server IP/Hostname of the remote NTP Server
      * @param {number} port Remote NTP Server port number
-     * @param {function(Object, Date)} callback(err, date) Async callback for 
+     * @param {function(Object, Date)} callback(err, date) Async callback for
      * the result date or eventually error.
      */
     exports.getNetworkTime = function (server, port, callback) {
+        if (callback === null || typeof callback !== "function") {
+            return;
+        }
+
+        server = server || exports.defaultNtpServer;
+        port = port || exports.defaultNtpPort;
+
         var client = dgram.createSocket("udp4"),
             ntpData = new Buffer(48);
 
@@ -37,7 +44,7 @@
             ntpData[i] = 0;
         }
 
-        var timeout = setTimeout(function() {
+        var timeout = setTimeout(function () {
             client.close();
             callback("Timeout waiting for NTP response.", null);
         }, exports.ntpReplyTimeout);
@@ -52,7 +59,7 @@
             client.once('message', function (msg) {
                 clearTimeout(timeout);
                 client.close();
-                
+
                 // Offset to get to the "Transmit Timestamp" field (time at which the reply
                 // departed the server for the client, in 64-bit timestamp format."
                 var offsetTransmitTime = 40,

package.json

@@ -1,7 +1,7 @@
 {
     "name": "ntp-client",
     "description": "Pure Javascript implementation of the NTP Client Protocol",
-    "version": "0.5.1",
+    "version": "0.5.2",
     "homepage": "https://github.com/moonpyk/node-ntp-client",
     "author": {
         "name": "Clément Bourgeois",
@@ -26,10 +26,11 @@
         "test": "grunt jshint nodeunit"
     },
     "devDependencies": {
+        "grunt": "~0.4.1",
         "grunt-contrib-jshint": "~0.6.0",
         "grunt-contrib-nodeunit": "~0.2.0",
         "grunt-contrib-watch": "~0.4.0",
-        "grunt": "~0.4.1"
+        "nodeunit": "~0.8.1"
     },
     "bin": {
         "node-ntp-client": "bin/node-ntp-client"
@@ -38,4 +39,4 @@
         "ntp",
         "date"
     ]
-}
+}

test/ntp-client_test.js

@@ -25,17 +25,29 @@
 
     exports.setUp = function (done) {
         // setup here
+        ntpClient.ntpReplyTimeout = 5000; // Reducing timeout to avoid warnings.
         done();
     };
 
-    exports.validNTPServer = function (test) {
-        ntpClient.ntpReplyTimeout = 5000; // Reducing timeout to avoid warnings.
+    exports.invalidUsage = function (test) {
+        test.doesNotThrow(function () {
+            ntpClient.getNetworkTime(ntpClient.defaultNtpServer, ntpClient.defaultNtpPort);
+        });
 
-        ntpClient.getNetworkTime(ntpClient.defaultNtpServer, ntpClient.defaultNtpPort, function (err, date) {
-            var now = new Date();
+        test.done();
+    };
 
+    exports.notBitchyAboutSomeParameters = function (test) {
+        ntpClient.getNetworkTime(null, null, function (err, date) {
+            test.ok(date !== null);
+            test.done();
+        });
+    };
+
+    exports.validNTPServer = function (test) {
+        ntpClient.getNetworkTime(ntpClient.defaultNtpServer, ntpClient.defaultNtpPort, function (err, date) {
             console.log();
-            console.log("System reported : %s", now);
+            console.log("System reported : %s", new Date());
 
             test.ok(err === null);
             test.ok(date !== null);