Fix --version flag getting the correct value during build (#32)

peteski22 · web-flow · commit 3b18f847ad6f · 2025-06-27T11:18:07.000+01:00
diff --git a/Makefile b/Makefile
@@ -15,7 +15,7 @@ VERSION := $(shell git describe --tags --always --dirty 2>/dev/null || echo "dev
 
 # Linker flags for injecting version
 # The path is MODULE_PATH/package.variableName
-LDFLAGS := -X '$(MODULE_PATH)/cmd.version=$(VERSION)'
+LDFLAGS := -X '$(MODULE_PATH)/internal/cmd.version=$(VERSION)'
 
 test:
 	go test ./...
diff --git a/internal/cmd/basecmd.go b/internal/cmd/basecmd.go
@@ -14,6 +14,8 @@ import (
 	"github.com/mozilla-ai/mcpd/v2/internal/runtime"
 )
 
+// version should not be moved/modified without consulting the Makefile,
+// as the path to this var is set on the LDFLAGS variable in the script.
 var version = "dev" // Set at build time using -ldflags
 
 // Version is used by other packages to retrieve the build version of mcpd.

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ import (`
`14`	`14`	`"github.com/mozilla-ai/mcpd/v2/internal/runtime"`
`15`	`15`	`)`
`16`	`16`
	`17`	`+// version should not be moved/modified without consulting the Makefile,`
	`18`	`+// as the path to this var is set on the LDFLAGS variable in the script.`
`17`	`19`	`var version = "dev" // Set at build time using -ldflags`
`18`	`20`
`19`	`21`	`// Version is used by other packages to retrieve the build version of mcpd.`