Bug fixes and button documentation

### UPDATED
- Separated logic for getting orb security buttons to its own method (`getOrbSecurityButtons`).
- Combined clean and dirty states for when checking if user is arming to the current state and alarm is not active.
- Changed wording for debug logs regarding stale login sessions (remove "now").
- Enhanced parsing of gateway and security panel manufacturer/model information.

### FIXED
- Comment typo for "sessions.axiosSyncCheck".
- Consistent alarm triggered when panel status is showing "Sensor Problem".

### ADDED
- Orb security button collections for "Arming Away", "Arming Stay" and "Disarm, Arm Away, Arm Stay".

Author: mrjackyliang

config.schema.json

@@ -272,7 +272,7 @@
                 },
                 {
                   "value": "ignoreSensorProblemStatus",
-                  "name": "Ignore Sensor Problem Status"
+                  "name": "Ignore \"Sensor Problem\" Panel Status"
                 }
               ]
             }

package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-adt-pulse",
   "displayName": "Homebridge ADT Pulse",
-  "version": "3.1.9",
+  "version": "3.2.0",
   "description": "Homebridge security system platform for ADT Pulse",
   "main": "./build/index.js",
   "exports": "./build/index.js",

src/lib/accessory.ts

@@ -172,7 +172,7 @@ export class ADTPulseAccessory {
     // Set the "AccessoryInformation" characteristics.
     this.#services.Information
       .setCharacteristic(this.#characteristic.Identify, false)
-      .setCharacteristic(this.#characteristic.Manufacturer, manufacturer ?? 'ADT')
+      .setCharacteristic(this.#characteristic.Manufacturer, manufacturer ?? 'N/A')
       .setCharacteristic(this.#characteristic.Model, model ?? 'N/A')
       .setCharacteristic(this.#characteristic.Name, name)
       .setCharacteristic(this.#characteristic.SerialNumber, serial ?? 'N/A')
@@ -626,7 +626,11 @@ export class ADTPulseAccessory {
 
     // Find the state for "Security System Alarm Type" (optional characteristic).
     if (mode === 'alarmType') {
-      if (isPanelAlarmActive(panelStatuses, this.#config?.options.includes('ignoreSensorProblemStatus') ?? false)) {
+      if (isPanelAlarmActive(
+        panelStatuses,
+        this.#state.data.orbSecurityButtons,
+        this.#config?.options.includes('ignoreSensorProblemStatus') ?? false,
+      )) {
         return 1;
       }
 
@@ -662,7 +666,11 @@ export class ADTPulseAccessory {
     switch (true) {
       case mode === 'current' && this.#activity.isBusy && this.#activity.setCurrentValue !== null:
         return this.#activity.setCurrentValue;
-      case mode === 'current' && isPanelAlarmActive(panelStatuses, this.#config?.options.includes('ignoreSensorProblemStatus') ?? false):
+      case mode === 'current' && isPanelAlarmActive(
+        panelStatuses,
+        this.#state.data.orbSecurityButtons,
+        this.#config?.options.includes('ignoreSensorProblemStatus') ?? false,
+      ):
         return this.#characteristic.SecuritySystemCurrentState.ALARM_TRIGGERED;
       case mode === 'current' && panelStates.includes('Armed Stay'):
         return this.#characteristic.SecuritySystemCurrentState.STAY_ARM;
@@ -748,7 +756,11 @@ export class ADTPulseAccessory {
     }
 
     // Only show as "On" if alarm is ringing.
-    return isPanelAlarmActive(panelStatuses, this.#config?.options.includes('ignoreSensorProblemStatus') ?? false);
+    return isPanelAlarmActive(
+      panelStatuses,
+      this.#state.data.orbSecurityButtons,
+      this.#config?.options.includes('ignoreSensorProblemStatus') ?? false,
+    );
   }
 
   /**
@@ -798,7 +810,11 @@ export class ADTPulseAccessory {
     const { panelStates } = this.#state.data.panelStatus;
 
     const condensedPanelStates = condensePanelStates(this.#characteristic, panelStates);
-    const isAlarmActive = isPanelAlarmActive(this.#state.data.panelStatus.panelStatuses, this.#config?.options.includes('ignoreSensorProblemStatus') ?? false);
+    const isAlarmActive = isPanelAlarmActive(
+      this.#state.data.panelStatus.panelStatuses,
+      this.#state.data.orbSecurityButtons,
+      this.#config?.options.includes('ignoreSensorProblemStatus') ?? false,
+    );
 
     // If panel status cannot be found or most likely "Status Unavailable".
     if (condensedPanelStates === undefined) {
@@ -937,7 +953,11 @@ export class ADTPulseAccessory {
     const { panelStates } = this.#state.data.panelStatus;
 
     const condensedPanelStates = condensePanelStates(this.#characteristic, panelStates);
-    const isAlarmActive = isPanelAlarmActive(this.#state.data.panelStatus.panelStatuses, this.#config?.options.includes('ignoreSensorProblemStatus') ?? false);
+    const isAlarmActive = isPanelAlarmActive(
+      this.#state.data.panelStatus.panelStatuses,
+      this.#state.data.orbSecurityButtons,
+      this.#config?.options.includes('ignoreSensorProblemStatus') ?? false,
+    );
 
     // If panel status cannot be found or most likely "Status Unavailable".
     if (condensedPanelStates === undefined) {