Allow jumping to unexplored areas (#115)

* descriptive errors

* combine failure messages + emerge undefined areas

* prepare to shorten obstruction message in the right branch

* partially shut luackeck up

* Create settingtypes.txt

* Update jump.lua

* whoops

* move settings

* cache config

* Update init.lua

Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>

* Update settingtypes.txt

* shut luacheck up

Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>

---------

Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>

Author: The4codeblocks

init.lua

@@ -13,6 +13,9 @@ jumpdrive = {
 
 		-- base technic power requirement
 		powerrequirement = tonumber(minetest.settings:get("jumpdrive.power_requirement")) or 2500,
+
+		-- allow emerging area on "uncharted" error
+		emerge_uncharted = core.settings:get_bool("jumpdrive.allow_emerge", false),
 	},
 
 	-- blacklisted nodes

is_area_empty.lua

@@ -30,12 +30,12 @@ jumpdrive.is_area_empty = function(pos1, pos2)
 		local id = data[index]
 
 		if id == c_ignore then
-			return false, "Uncharted"
+			return false, "uncharted"
 		end
 
 		if not buildable_to_nodes[id] then
 			-- not buildable_to
-			return false, "Occupied"
+			return false, "occupied"
 		end
 	end
 	end

jump.lua

@@ -4,8 +4,10 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 
 	local targetPos = jumpdrive.get_meta_pos(pos)
 
-	if jumpdrive.check_mapgen(pos) then
-		return false, "Error: mapgen was active in this area, please try again later for your own safety!"
+	local mapgen_distance = jumpdrive.check_mapgen(pos)
+	if mapgen_distance then
+		return false, "Error: mapgen was active "..math.floor(mapgen_distance)
+			.. " / 200 nodes away, please try again later for your own safety!"
 	end
 
 	local meta = minetest.get_meta(pos)
@@ -50,7 +52,7 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 		meta:set_int("simulation_expiry", shape.expiry)
 	end
 
-	local msg = nil
+	local msg = ""
 	local success = true
 
 	local blacklisted_pos_list = minetest.find_nodes_in_area(source_pos1, source_pos2, jumpdrive.blacklist)
@@ -60,12 +62,13 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 	end
 
 	if minetest.find_node_near(targetPos, radius, "vacuum:vacuum", true) then
-		msg = "Warning: Jump-target is in vacuum!"
+		msg = msg .. "\nWarning: Jump-target is in vacuum!"
 	end
 
-	if minetest.find_node_near(targetPos, radius, "ignore", true) then
-		return false, "Warning: Jump-target is in uncharted area"
-	end
+--	-- found to be useless/indescriptive and is superseded by "Jump-target is uncharted"
+--	if minetest.find_node_near(targetPos, radius, "ignore", true) then
+--		return false, "Warning: Jump-target is in uncharted area"
+--	end
 
 	if jumpdrive.is_area_protected(source_pos1, source_pos2, playername) then
 		return false, "Jump-source is protected!"
@@ -78,7 +81,15 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 	local is_empty, empty_msg = jumpdrive.is_area_empty(target_pos1, target_pos2)
 
 	if not is_empty then
-		msg = "Jump-target is obstructed (" .. empty_msg .. ")"
+		if jumpdrive.config.emerge_uncharted and empty_msg == "uncharted" then
+			local callback = function(_, _, calls_remaining, _)
+				if calls_remaining == 0 then
+					core.chat_send_player(playername, "Charting complete!")
+				end
+			end
+			core.emerge_area(target_pos1, target_pos2, callback)
+		end
+		msg = msg .. "\nJump-target is " .. empty_msg
 		success = false
 	end
 
@@ -87,7 +98,7 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 
 	if not preflight_result.success then
 		-- check failed in customization
-		msg = "Preflight check failed!"
+		msg = msg .. "\nPreflight check failed!"
 		if preflight_result.message then
 			msg = preflight_result.message
 		end
@@ -99,7 +110,7 @@ jumpdrive.simulate_jump = function(pos, player, show_marker)
 
 	if powerstorage < power_req then
 		-- not enough power
-		msg = "Not enough power: required=" .. math.floor(power_req) .. ", actual: " .. powerstorage .. " EU"
+		msg = msg .. "\nNot enough power: required=" .. math.floor(power_req) .. ", actual: " .. powerstorage .. " EU"
 		success = false
 	end
 

mapgen.lua

@@ -54,11 +54,12 @@ minetest.register_globalstep(function(dtime)
 end)
 
 
--- true = mapgen recently active in that area
+-- any number = mapgen recently active in that area
 jumpdrive.check_mapgen = function(pos)
 	for _, event in ipairs(events) do
-		if vector.distance(pos, event.minp) < 200 then
-			return true
+		local mapgen_distance = vector.distance(pos, event.minp)
+		if mapgen_distance < 200 then
+			return mapgen_distance
 		end
 	end
 

settingtypes.txt

@@ -0,0 +1,2 @@
+# Allow jumpdrives to generate ungenerated areas
+jumpdrive.allow_emerge (Chart uncharted jump targets) bool false