Skip to content

Commit 1e9dac4

Browse files
reuse endTick()
1 parent 8ed3557 commit 1e9dac4

File tree

9 files changed

+14
-16
lines changed

9 files changed

+14
-16
lines changed

src/engraving/compat/midi/pausemap.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ void PauseMap::calculate(const Score* s)
6060

6161
for (const RepeatSegment* rs : s->repeatList()) {
6262
int startTick = rs->tick;
63-
int endTick = startTick + rs->len();
63+
int endTick = rs->endTick();
6464
int tickOffset = rs->utick - rs->tick;
6565

6666
auto se = tempomap->lower_bound(startTick);

src/engraving/dom/repeatlist.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,9 @@ void RepeatList::updateTempo()
210210
s->utime = t;
211211
double ct = tl->tick2time(s->tick);
212212
s->timeOffset = t - ct;
213-
utick += s->len();
214-
t += tl->tick2time(s->tick + s->len()) - ct;
213+
int len = s->len();
214+
utick += len;
215+
t += tl->tick2time(s->tick + len) - ct;
215216
}
216217
}
217218

@@ -250,7 +251,7 @@ int RepeatList::tick2utick(int tick) const
250251
return 0;
251252
}
252253
for (const RepeatSegment* s : *this) {
253-
if (tick >= s->tick && tick < (s->tick + s->len())) {
254+
if (tick >= s->tick && tick < s->endTick()) {
254255
return s->utick + (tick - s->tick);
255256
}
256257
}

src/engraving/dom/score.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5138,7 +5138,7 @@ String Score::extractLyrics()
51385138
const RepeatList& rlist = repeatList();
51395139
for (const RepeatSegment* rs : rlist) {
51405140
Fraction startTick = Fraction::fromTicks(rs->tick);
5141-
Fraction endTick = startTick + Fraction::fromTicks(rs->len());
5141+
Fraction endTick = Fraction::fromTicks(rs->endTick());
51425142
for (Measure* m = tick2measure(startTick); m; m = m->nextMeasure()) {
51435143
size_t playCount = m->playbackCount();
51445144
for (Segment* seg = m->first(st); seg; seg = seg->next(st)) {

src/engraving/dom/unrollrepeats.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ MasterScore* MasterScore::unrollRepeats()
150150
bool first = true;
151151
for (const RepeatSegment* rs: original->repeatList()) {
152152
Fraction startTick = Fraction::fromTicks(rs->tick);
153-
Fraction endTick = Fraction::fromTicks(rs->tick + rs->len());
153+
Fraction endTick = Fraction::fromTicks(rs->endTick());
154154

155155
// first segment left from clone, everything past that removed
156156
if (first) {

src/engraving/playback/playbackcontext.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,7 @@ void PlaybackContext::update(const ID partId, const Score* score, bool expandRep
317317
}
318318
}
319319

320-
handleSpanners(partId, score, repeatSegment->tick,
321-
repeatSegment->tick + repeatSegment->len(), tickPositionOffset);
322-
320+
handleSpanners(partId, score, repeatSegment->tick, repeatSegment->endTick(), tickPositionOffset);
323321
handleMeasureRepeats(measureRepeats, tickPositionOffset);
324322
}
325323

src/engraving/playback/playbackmodel.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ void PlaybackModel::updateEvents(const int tickFrom, const int tickTo, const tra
576576
for (const RepeatSegment* repeatSegment : repeatList()) {
577577
int tickPositionOffset = repeatSegment->utick - repeatSegment->tick;
578578
int repeatStartTick = repeatSegment->tick;
579-
int repeatEndTick = repeatStartTick + repeatSegment->len();
579+
int repeatEndTick = repeatSegment->endTick();
580580

581581
if (repeatStartTick > tickTo || repeatEndTick <= tickFrom) {
582582
continue;
@@ -831,7 +831,7 @@ void PlaybackModel::clearExpiredEvents(const int tickFrom, const int tickTo, con
831831
for (const RepeatSegment* repeatSegment : repeatList()) {
832832
int tickPositionOffset = repeatSegment->utick - repeatSegment->tick;
833833
int repeatStartTick = repeatSegment->tick;
834-
int repeatEndTick = repeatStartTick + repeatSegment->len();
834+
int repeatEndTick = repeatSegment->endTick();
835835

836836
if (repeatStartTick > tickTo || repeatEndTick <= tickFrom) {
837837
continue;

src/engraving/tests/repeat_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ void Engraving_RepeatTests::repeat(const char* path, const String& ref)
5252

5353
for (const RepeatSegment* rs : score->repeatList()) {
5454
int startTick = rs->tick;
55-
int endTick = startTick + rs->len();
55+
int endTick = rs->endTick();
5656

5757
for (const Measure* m = score->tick2measure(Fraction::fromTicks(startTick)); m; m = m->nextMeasure()) {
5858
sl.append(String::number(m->no() + 1));

src/importexport/midi/internal/midiexport/exportmidi.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void ExportMidi::writeHeader(const CompatMidiRendererInternal::Context& context)
8484
TimeSigMap* sigmap = m_score->sigmap();
8585
for (const RepeatSegment* rs : m_score->repeatList()) {
8686
int startTick = rs->tick;
87-
int endTick = startTick + rs->len();
87+
int endTick = rs->endTick();
8888
int tickOffset = rs->utick - rs->tick;
8989

9090
auto bs = sigmap->lower_bound(startTick);
@@ -361,8 +361,7 @@ bool ExportMidi::write(QIODevice* device, bool midiExpandRepeats, bool exportRPN
361361

362362
// Export lyrics and RehearsalMarks as Meta events
363363
for (const RepeatSegment* rs : m_score->repeatList()) {
364-
int startTick = rs->tick;
365-
int endTick = startTick + rs->len();
364+
int endTick = rs->endTick();
366365
int tickOffset = rs->utick - rs->tick;
367366

368367
// export Lyrics

src/notation/internal/positionswriter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ void PositionsWriter::writeEventsPositions(deprecated::XmlWriter& writer, const
238238

239239
for (const mu::engraving::RepeatSegment* repeatSegment : score->repeatList()) {
240240
int startTick = repeatSegment->tick;
241-
int endTick = startTick + repeatSegment->len();
241+
int endTick = repeatSegment->endTick();
242242
int tickOffset = repeatSegment->utick - repeatSegment->tick;
243243
for (Measure* measure = score->tick2measureMM(Fraction::fromTicks(startTick)); measure; measure = measure->nextMeasureMM()) {
244244
if (m_elementType == ElementType::SEGMENT) {

0 commit comments

Comments
 (0)