Skip to content

Commit 6240ef9

Browse files
zacjansheskizacjansheski
authored
Handbells and Handchimes (#29363)
Make Hand Bells one word Add Handchimes
1 parent 2e7a81f commit 6240ef9

File tree

4 files changed

+52
-16
lines changed

4 files changed

+52
-16
lines changed

‎share/instruments/instruments.xml

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6648,10 +6648,10 @@
66486648
</Instrument>
66496649
<Instrument id="hand-bells">
66506650
<family>pitched-metal-percussion</family>
6651-
<trackName>Hand Bells</trackName>
6652-
<longName>Hand Bells</longName>
6653-
<shortName>Ha. Be.</shortName>
6654-
<description>Tuned hand bells.</description>
6651+
<trackName>Handbells</trackName>
6652+
<longName>Handbells</longName>
6653+
<shortName>H.B.</shortName>
6654+
<description>Tuned hand-held bells.</description>
66556655
<musicXMLid>pitched-percussion.handbells</musicXMLid>
66566656
<staves>2</staves>
66576657
<transposingClef>G</transposingClef>
@@ -6673,6 +6673,33 @@
66736673
<genre>common</genre>
66746674
<genre>choral</genre>
66756675
</Instrument>
6676+
<Instrument id="hand-chimes">
6677+
<family>pitched-metal-percussion</family>
6678+
<trackName>Handchimes</trackName>
6679+
<longName>Handchimes</longName>
6680+
<shortName>H.C.</shortName>
6681+
<description>Tuned hand-held chimes.</description>
6682+
<musicXMLid>pitched-percussion.handchimes</musicXMLid>
6683+
<staves>2</staves>
6684+
<transposingClef>G</transposingClef>
6685+
<concertClef>G8va</concertClef>
6686+
<bracket>1</bracket>
6687+
<bracketSpan>2</bracketSpan>
6688+
<barlineSpan>2</barlineSpan>
6689+
<transposingClef staff="2">F</transposingClef>
6690+
<concertClef staff="2">F8va</concertClef>
6691+
<aPitchRange>36-97</aPitchRange>
6692+
<pPitchRange>36-97</pPitchRange>
6693+
<singleNoteDynamics>0</singleNoteDynamics>
6694+
<transposeDiatonic>7</transposeDiatonic>
6695+
<transposeChromatic>12</transposeChromatic>
6696+
<Channel>
6697+
<!--MIDI: Bank 0, Prog 112; MS General: Tinker Bell-->
6698+
<program value="112"/> <!--Tinkle Bell-->
6699+
</Channel>
6700+
<genre>common</genre>
6701+
<genre>choral</genre>
6702+
</Instrument>
66766703
<Instrument id="orff-soprano-glockenspiel">
66776704
<family>orff-percussion</family>
66786705
<trackName>Orff Soprano Glockenspiel</trackName>

‎share/instruments/instrumentsxml.h

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3634,14 +3634,23 @@ QT_TRANSLATE_NOOP3("engraving/instruments", "Tuned Gongs", "tuned-gongs longName
36343634
//: shortName for Tuned Gongs; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
36353635
QT_TRANSLATE_NOOP3("engraving/instruments", "Td. Gon.", "tuned-gongs shortName"),
36363636

3637-
//: description for Hand Bells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3638-
QT_TRANSLATE_NOOP3("engraving/instruments", "Tuned hand bells.", "hand-bells description"),
3639-
//: trackName for Hand Bells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3640-
QT_TRANSLATE_NOOP3("engraving/instruments", "Hand Bells", "hand-bells trackName"),
3641-
//: longName for Hand Bells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3642-
QT_TRANSLATE_NOOP3("engraving/instruments", "Hand Bells", "hand-bells longName"),
3643-
//: shortName for Hand Bells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3644-
QT_TRANSLATE_NOOP3("engraving/instruments", "Ha. Be.", "hand-bells shortName"),
3637+
//: description for Handbells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3638+
QT_TRANSLATE_NOOP3("engraving/instruments", "Tuned hand-held bells.", "hand-bells description"),
3639+
//: trackName for Handbells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3640+
QT_TRANSLATE_NOOP3("engraving/instruments", "Handbells", "hand-bells trackName"),
3641+
//: longName for Handbells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3642+
QT_TRANSLATE_NOOP3("engraving/instruments", "Handbells", "hand-bells longName"),
3643+
//: shortName for Handbells; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3644+
QT_TRANSLATE_NOOP3("engraving/instruments", "H.B.", "hand-bells shortName"),
3645+
3646+
//: description for Handchimes; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3647+
QT_TRANSLATE_NOOP3("engraving/instruments", "Tuned hand-held chimes.", "hand-chimes description"),
3648+
//: trackName for Handchimes; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3649+
QT_TRANSLATE_NOOP3("engraving/instruments", "Handchimes", "hand-chimes trackName"),
3650+
//: longName for Handchimes; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3651+
QT_TRANSLATE_NOOP3("engraving/instruments", "Handchimes", "hand-chimes longName"),
3652+
//: shortName for Handchimes; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
3653+
QT_TRANSLATE_NOOP3("engraving/instruments", "H.C.", "hand-chimes shortName"),
36453654

36463655
//: description for Orff Soprano Glockenspiel; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names
36473656
QT_TRANSLATE_NOOP3("engraving/instruments", "Soprano glockenspiel for the Orff Schulwerk.", "orff-soprano-glockenspiel description"),

‎src/engraving/playback/mapping/percussionssetupdataresolver.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ PlaybackSetupData PercussionsSetupDataResolver::doResolve(const Instrument* inst
7070
SoundSubCategory::Opera } } },
7171
{ "wind-gong", { SoundId::Gong, SoundCategory::Percussions, { SoundSubCategory::Metal,
7272
SoundSubCategory::Wind } } },
73-
{ "hand-bells", { SoundId::Bell, SoundCategory::Percussions, { SoundSubCategory::Metal,
74-
SoundSubCategory::Hand } } },
73+
{ "hand-bells", { SoundId::Bell, SoundCategory::Percussions, { SoundSubCategory::Hand } } },
74+
{ "hand-chimes", { SoundId::Chimes, SoundCategory::Percussions, { SoundSubCategory::Hand } } },
7575

7676
{ "orff-soprano-glockenspiel", { SoundId::Glockenspiel, SoundCategory::Percussions, { SoundSubCategory::Soprano,
7777
SoundSubCategory::Orff } } },

‎src/framework/audio/worker/internal/synthesizers/fluidsynth/soundmapping.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -702,8 +702,8 @@ static const auto& mappingByCategory(const mpe::SoundCategory category)
702702
mpe::SoundSubCategory::Bowl } }, { midi::Program(0, 11) } },
703703
{ { mpe::SoundId::Chain, { mpe::SoundSubCategory::Metal } }, { midi::Program(128, 0) } },
704704

705-
{ { mpe::SoundId::Bell, { mpe::SoundSubCategory::Metal,
706-
mpe::SoundSubCategory::Hand } }, { midi::Program(0, 112) } },
705+
{ { mpe::SoundId::Bell, { mpe::SoundSubCategory::Hand } }, { midi::Program(0, 112) } },
706+
{ { mpe::SoundId::Chimes, { mpe::SoundSubCategory::Hand } }, { midi::Program(0, 112) } },
707707
{ { mpe::SoundId::Bell, { mpe::SoundSubCategory::Plate,
708708
mpe::SoundSubCategory::Metal } }, { midi::Program(0, 11) } },
709709
{ { mpe::SoundId::Bell, { mpe::SoundSubCategory::Metal } }, { midi::Program(128, 0) } },

0 commit comments

Comments
 (0)