fixed binding loop on drag from palette

igorkorsukov · igorkorsukov · commit d61806d0e62c · 2025-08-21T16:22:07.000+03:00
diff --git a/src/palette/qml/MuseScore/Palette/internal/PaletteGridView.qml b/src/palette/qml/MuseScore/Palette/internal/PaletteGridView.qml
@@ -570,9 +570,15 @@ StyledGridView {
                 if (!ui.isSystemDragSupported) {
                     draggedIcon.Drag.mimeData = model.mimeData
                     draggedIcon.Drag.active = dragActive
+                } else {
+                    Qt.callLater(paletteCell.updateDragActive)
                 }
             }
 
+            function updateDragActive() {
+                paletteCell.Drag.active = mouseArea.drag.active
+            }
+
             mouseArea.onPressed: function(e) {
                 paletteCell.beginDrag()
             }
@@ -595,7 +601,6 @@ StyledGridView {
                 removeSelectedCells()
             }
 
-            Drag.active: ui.isSystemDragSupported ? mouseArea.drag.active : false
             Drag.dragType: ui.isSystemDragSupported ? Drag.Automatic : Drag.Internal
             Drag.supportedActions: Qt.CopyAction | (model.editable ? Qt.MoveAction : 0)
             Drag.mimeData: Drag.active ? mimeData : {}

Original file line number	Diff line number	Diff line change
`@@ -570,9 +570,15 @@ StyledGridView {`
`570`	`570`	`if (!ui.isSystemDragSupported) {`
`571`	`571`	`draggedIcon.Drag.mimeData = model.mimeData`
`572`	`572`	`draggedIcon.Drag.active = dragActive`
	`573`	`+ } else {`
	`574`	`+ Qt.callLater(paletteCell.updateDragActive)`
`573`	`575`	`}`
`574`	`576`	`}`
`575`	`577`
	`578`	`+ function updateDragActive() {`
	`579`	`+ paletteCell.Drag.active = mouseArea.drag.active`
	`580`	`+ }`
	`581`	`+`
`576`	`582`	`mouseArea.onPressed: function(e) {`
`577`	`583`	`paletteCell.beginDrag()`
`578`	`584`	`}`
`@@ -595,7 +601,6 @@ StyledGridView {`
`595`	`601`	`removeSelectedCells()`
`596`	`602`	`}`
`597`	`603`
`598`		`- Drag.active: ui.isSystemDragSupported ? mouseArea.drag.active : false`
`599`	`604`	`Drag.dragType: ui.isSystemDragSupported ? Drag.Automatic : Drag.Internal`
`600`	`605`	`Drag.supportedActions: Qt.CopyAction \| (model.editable ? Qt.MoveAction : 0)`
`601`	`606`	`Drag.mimeData: Drag.active ? mimeData : {}`