Skip to content

Commit 50aef43

Browse files
committed
Implemented ResultSingleOptional testkit request
1 parent 5e14063 commit 50aef43

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

testkit-backend/lib/testkit/backend/messages/requests/get_features.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class GetFeatures < Request
1919
'Feature:API:Result.List' => 'ja',
2020
'Feature:API:Result.Peek' => 'ja',
2121
'Feature:API:Result.Single' => 'ja',
22-
'Feature:API:Result.SingleOptional' => '',
22+
'Feature:API:Result.SingleOptional' => 'jar',
2323
'Feature:API:RetryableExceptions' => '',
2424
'Feature:API:Session:AuthConfig' => 'a',
2525
'Feature:API:Session:NotificationsConfig' => 'a',
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
module Testkit::Backend::Messages
2+
module Requests
3+
class ResultSingleOptional < Request
4+
def process
5+
result = fetch(result_id)
6+
record = begin
7+
{ values: result.single.values.map(&method(:to_testkit)) }
8+
rescue Neo4j::Driver::Exceptions::NoSuchRecordException
9+
nil
10+
end
11+
named_entity('RecordOptional', record:, warnings: [])
12+
end
13+
end
14+
end
15+
end

testkit-backend/lib/testkit/backend/messages/requests/start_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ class StartTest < Request
44
SKIPPED_TESTS = {
55
'neo4j.test_direct_driver.TestDirectDriver.test_custom_resolver': 'Does not call resolver for direct connections', # skip for java hardcoded in testkit
66
'stub.session_run_parameters.test_session_run_parameters.TestSessionRunParameters.test_empty_query': 'rejects empty string', # skip for java hardcoded in testkit
7+
'stub.iteration.test_result_optional_single.TestResultSingleOptional.test_result_single_optional_with_2_records': 'Not implemented for ruby driver in testkit',
8+
'stub.iteration.test_result_optional_single.TestResultSingleOptional.test_result_single_optional_with_disconnect': 'Not implemented for ruby driver in testkit',
79
# 'stub.iteration.test_iteration_tx_run.TestIterationTxRun.test_nested': 'completely pulls the first query before running the second',
810
# 'stub.optimizations.test_optimizations.TestOptimizations.test_uses_implicit_default_arguments': 'Driver does not implement optimization for qid in explicit transaction',
911
# 'stub.optimizations.test_optimizations.TestOptimizations.test_uses_implicit_default_arguments_multi_query': 'Driver does not implement optimization for qid in explicit transaction',

0 commit comments

Comments
 (0)