Skip to content

Commit 07d228f

Browse files
authored
Replace incorrect characters in tags (#25)
1 parent 9777f37 commit 07d228f

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

neptune_mlflow/data_loader.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from __future__ import print_function
1717

1818
import os
19+
import re
1920
import click
2021
import mlflow
2122
import path as path_utils
@@ -38,7 +39,7 @@ def run(self):
3839

3940
for experiment in experiments:
4041
run_infos = mlflow_client.list_run_infos(experiment_id=experiment.experiment_id)
41-
existing_experiments = self._project.get_experiments(tag=experiment.name.lower())
42+
existing_experiments = self._project.get_experiments(tag=DataLoader._to_proper_tag(experiment.name))
4243
existing_run_uuids = set([
4344
str(e.get_properties().get(DataLoader.MLFLOW_RUN_ID_PROPERTY)) for e in existing_experiments
4445
])
@@ -109,11 +110,15 @@ def _get_properties(experiment, run):
109110

110111
@staticmethod
111112
def _get_tags(experiment, run):
112-
tags = [experiment.name.lower(), 'mlflow']
113+
tags = [DataLoader._to_proper_tag(experiment.name), 'mlflow']
113114
if DataLoader._get_mlflow_run_name(run):
114-
tags.append(DataLoader._get_mlflow_run_name(run).lower())
115+
tags.append(DataLoader._to_proper_tag(DataLoader._get_mlflow_run_name(run)))
115116
return tags
116117

118+
@staticmethod
119+
def _to_proper_tag(string):
120+
return re.sub("[^a-zA-Z0-9\\-_]", "_", string).lower()
121+
117122
@staticmethod
118123
def _get_metric_file(experiment, run_info, metric_key):
119124
return "mlruns/{}/{}/metrics/{}".format(experiment.experiment_id, run_info.run_uuid, metric_key)

0 commit comments

Comments
 (0)