remove pointless initialisation of integration step size to max 0.01 ms

C.A.P. Linssen · C.A.P. Linssen · commit 10c344917404 · 2024-12-09T11:06:15.000+01:00
diff --git a/models/aeif_cond_alpha.cpp b/models/aeif_cond_alpha.cpp
@@ -384,9 +384,9 @@ nest::aeif_cond_alpha::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/aeif_cond_alpha_astro.cpp b/models/aeif_cond_alpha_astro.cpp
@@ -386,9 +386,9 @@ nest::aeif_cond_alpha_astro::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/aeif_cond_alpha_multisynapse.cpp b/models/aeif_cond_alpha_multisynapse.cpp
@@ -347,7 +347,7 @@ aeif_cond_alpha_multisynapse::Buffers_::Buffers_( aeif_cond_alpha_multisynapse&
   , c_( nullptr )
   , e_( nullptr )
   , step_( Time::get_resolution().get_ms() )
-  , IntegrationStep_( std::min( 0.01, step_ ) )
+  , IntegrationStep_( step_ )
   , I_stim_( 0.0 )
 {
 }
@@ -416,9 +416,9 @@ aeif_cond_alpha_multisynapse::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.c_ )
   {
diff --git a/models/aeif_cond_beta_multisynapse.cpp b/models/aeif_cond_beta_multisynapse.cpp
@@ -355,7 +355,7 @@ aeif_cond_beta_multisynapse::Buffers_::Buffers_( aeif_cond_beta_multisynapse& n
   , c_( nullptr )
   , e_( nullptr )
   , step_( Time::get_resolution().get_ms() )
-  , IntegrationStep_( std::min( 0.01, step_ ) )
+  , IntegrationStep_( step_ )
   , I_stim_( 0.0 )
 {
 }
@@ -424,9 +424,9 @@ aeif_cond_beta_multisynapse::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.c_ )
   {
diff --git a/models/aeif_cond_exp.cpp b/models/aeif_cond_exp.cpp
@@ -379,9 +379,9 @@ nest::aeif_cond_exp::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/aeif_psc_alpha.cpp b/models/aeif_psc_alpha.cpp
@@ -374,9 +374,9 @@ nest::aeif_psc_alpha::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/aeif_psc_delta.cpp b/models/aeif_psc_delta.cpp
@@ -351,9 +351,9 @@ nest::aeif_psc_delta::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/aeif_psc_delta_clopath.cpp b/models/aeif_psc_delta_clopath.cpp
@@ -417,9 +417,9 @@ nest::aeif_psc_delta_clopath::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/aeif_psc_exp.cpp b/models/aeif_psc_exp.cpp
@@ -369,9 +369,9 @@ nest::aeif_psc_exp::init_buffers_()
   B_.logger_.reset();
 
   B_.step_ = Time::get_resolution().get_ms();
-
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ =
+    B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by
+              // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data
 
   if ( not B_.s_ )
   {
diff --git a/models/glif_cond.cpp b/models/glif_cond.cpp
@@ -465,7 +465,7 @@ nest::glif_cond::Buffers_::Buffers_( glif_cond& n )
   , c_( nullptr )
   , e_( nullptr )
   , step_( Time::get_resolution().get_ms() )
-  , IntegrationStep_( std::min( 0.01, step_ ) )
+  , IntegrationStep_( step_ )
   , I_( 0.0 )
 {
 }
@@ -534,8 +534,7 @@ nest::glif_cond::init_buffers_()
   B_.logger_.reset();   // includes resize
 
   B_.step_ = Time::get_resolution().get_ms();
-  // We must integrate this model with high-precision to obtain decent results
-  B_.IntegrationStep_ = std::min( 0.01, B_.step_ );
+  B_.IntegrationStep_ = B_.step_;    // initial value for numerical integrator step size; this will anyway be overwritten by gsl_odeiv_evolve_apply()
 
   if ( not B_.c_ )
   {

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ aeif_cond_alpha_multisynapse::Buffers_::Buffers_( aeif_cond_alpha_multisynapse&`
`347`	`347`	`, c_( nullptr )`
`348`	`348`	`, e_( nullptr )`
`349`	`349`	`, step_( Time::get_resolution().get_ms() )`
`350`		`- , IntegrationStep_( std::min( 0.01, step_ ) )`
	`350`	`+ , IntegrationStep_( step_ )`
`351`	`351`	`, I_stim_( 0.0 )`
`352`	`352`	`{`
`353`	`353`	`}`
`@@ -416,9 +416,9 @@ aeif_cond_alpha_multisynapse::init_buffers_()`
`416`	`416`	`B_.logger_.reset();`
`417`	`417`
`418`	`418`	`B_.step_ = Time::get_resolution().get_ms();`
`419`		`-`
`420`		`- // We must integrate this model with high-precision to obtain decent results`
`421`		`- B_.IntegrationStep_ = std::min( 0.01, B_.step_ );`
	`419`	`+ B_.IntegrationStep_ =`
	`420`	`+ B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by`
	`421`	`+ // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data`
`422`	`422`
`423`	`423`	`if ( not B_.c_ )`
`424`	`424`	`{`
Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ aeif_cond_beta_multisynapse::Buffers_::Buffers_( aeif_cond_beta_multisynapse& n`
`355`	`355`	`, c_( nullptr )`
`356`	`356`	`, e_( nullptr )`
`357`	`357`	`, step_( Time::get_resolution().get_ms() )`
`358`		`- , IntegrationStep_( std::min( 0.01, step_ ) )`
	`358`	`+ , IntegrationStep_( step_ )`
`359`	`359`	`, I_stim_( 0.0 )`
`360`	`360`	`{`
`361`	`361`	`}`
`@@ -424,9 +424,9 @@ aeif_cond_beta_multisynapse::init_buffers_()`
`424`	`424`	`B_.logger_.reset();`
`425`	`425`
`426`	`426`	`B_.step_ = Time::get_resolution().get_ms();`
`427`		`-`
`428`		`- // We must integrate this model with high-precision to obtain decent results`
`429`		`- B_.IntegrationStep_ = std::min( 0.01, B_.step_ );`
	`427`	`+ B_.IntegrationStep_ =`
	`428`	`+ B_.step_; // reasonable initial value for numerical integrator step size; this will anyway be overwritten by`
	`429`	`+ // gsl_odeiv_evolve_apply(), but it might confuse the integrator if it contains uninitialised data`
`430`	`430`
`431`	`431`	`if ( not B_.c_ )`
`432`	`432`	`{`
Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,7 @@ nest::glif_cond::Buffers_::Buffers_( glif_cond& n )`
`465`	`465`	`, c_( nullptr )`
`466`	`466`	`, e_( nullptr )`
`467`	`467`	`, step_( Time::get_resolution().get_ms() )`
`468`		`- , IntegrationStep_( std::min( 0.01, step_ ) )`
	`468`	`+ , IntegrationStep_( step_ )`
`469`	`469`	`, I_( 0.0 )`
`470`	`470`	`{`
`471`	`471`	`}`
`@@ -534,8 +534,7 @@ nest::glif_cond::init_buffers_()`
`534`	`534`	`B_.logger_.reset(); // includes resize`
`535`	`535`
`536`	`536`	`B_.step_ = Time::get_resolution().get_ms();`
`537`		`- // We must integrate this model with high-precision to obtain decent results`
`538`		`- B_.IntegrationStep_ = std::min( 0.01, B_.step_ );`
	`537`	`+ B_.IntegrationStep_ = B_.step_; // initial value for numerical integrator step size; this will anyway be overwritten by gsl_odeiv_evolve_apply()`
`539`	`538`
`540`	`539`	`if ( not B_.c_ )`
`541`	`540`	`{`