Overcome MPI c++ bindings for MUSIC related files

[filimarc]

Is your feature request related to a problem? Please describe.

The C++ bindings are long deprecated, and on some HPC systems, MPI is not configured to use them. When NEST is compiled with MUSIC support, it still relies on these C++ bindings, leading to issues during the compilation process.

Describe the solution you'd like
substitue the bindings for MPI in:
music_manager.h
mpi_manager_impl.h

[github-actions]

Issue automatically marked stale!

[gtrensch]

If the problem still persists, please can you provide additional diagnostic information, i.e. the platform, MPI version and build logs?

[filimarc]

Yes it still exist.

Platform
CentOS Linux 8
g++ (Spack GCC) 10.2.0
Open MPI: 4.1.1
NEST 3.7
Music 1.2.1

Compile

cmake ..  -Dwith-mpi=ON -Dwith-music=ON

make

LOG

In file included from /g100_work/ERI2_E2_PAVIA/SW/GitFolders/nest-simulator-3.7/nestkernel/kernel_manager.h:38,
                 from /g100_work/ERI2_E2_PAVIA/SW/GitFolders/nest-simulator-3.7/nestkernel/random_manager.cpp:30:
/g100_work/ERI2_E2_PAVIA/SW/GitFolders/nest-simulator-3.7/nestkernel/music_manager.h:82:3: error: 'MPI' does not name a type; did you mean 'M_PI'?
   82 |   MPI::Intracomm communicator();
      |   ^~~
      |   M_PI
make[2]: *** [nestkernel/CMakeFiles/nestkernel.dir/build.make:622: nestkernel/CMakeFiles/nestkernel.dir/nest.cpp.o] Error 1
make[2]: *** [nestkernel/CMakeFiles/nestkernel.dir/build.make:538: nestkernel/CMakeFiles/nestkernel.dir/conn_builder.cpp.o] Error 1
make[2]: *** [nestkernel/CMakeFiles/nestkernel.dir/build.make:440: nestkernel/CMakeFiles/nestkernel.dir/recording_device.cpp.o] Error 1
In file included from /g100_work/ERI2_E2_PAVIA/SW/GitFolders/nest-simulator-3.7/nestkernel/vp_manager_impl.h:31,
                 from /g100_work/ERI2_E2_PAVIA/SW/GitFolders/nest-simulator-3.7/nestkernel/random_manager.cpp:32:
/g100_work/ERI2_E2_PAVIA/SW/GitFolders/nest-simulator-3.7/nestkernel/mpi_manager_impl.h:48:8: error: 'MPI' does not name a type; did you mean 'M_PI'?
   48 | extern MPI::Intracomm comm;
      |        ^~~
      |        M_PI

solution hypothesis

The problems is the usage of CXX bindings, that are deprecated for mpi, in some specific header file when music is called.
In mycase the env openmpi do not have the bindings enabled.
ompi_info | grep bindings gives:

              C bindings: yes
            C++ bindings: no
           Java bindings: no

So i was wondering if it is possible to substitute the bindings.
Thanks

[github-actions]

Issue automatically marked stale!