Merge pull request #321 from digitalocean/fix-linter

Fix linter

Author: Zach Moody

.github/workflows/py3.yml

@@ -26,7 +26,7 @@ jobs:
         run: pip install . black==19.10b0 pytest
 
       - name: Run Linter
-        run: black --diff pynetbox tests
+        run: black --diff --check pynetbox tests
 
       - name: Run Tests
         run: pytest

pynetbox/core/app.py

@@ -149,7 +149,7 @@ def __init__(self, api):
         self.api = api
 
     def __getattr__(self, name):
-        return App(self.api, 'plugins/{}'.format(name))
+        return App(self.api, "plugins/{}".format(name))
 
     def installed_plugins(self):
         """ Returns raw response with installed plugins

pynetbox/core/response.py

@@ -281,7 +281,7 @@ def list_parser(list_item):
 
     def _endpoint_from_url(self, url):
         # Remove the base URL from the beginning
-        url = url[len(self.api.base_url):]
+        url = url[len(self.api.base_url) :]
         if url.startswith("/"):
             url = url[1:]
         app, name = urlsplit(url).path.split("/")[:2]

tests/test_api.py

@@ -52,8 +52,7 @@ class ResponseHeadersWithVersion:
         ok = True
 
     @patch(
-        "requests.sessions.Session.get",
-        return_value=ResponseHeadersWithVersion(),
+        "requests.sessions.Session.get", return_value=ResponseHeadersWithVersion(),
     )
     def test_api_version(self, *_):
         api = pynetbox.api(host,)
@@ -64,8 +63,7 @@ class ResponseHeadersWithoutVersion:
         ok = True
 
     @patch(
-        "requests.sessions.Session.get",
-        return_value=ResponseHeadersWithoutVersion(),
+        "requests.sessions.Session.get", return_value=ResponseHeadersWithoutVersion(),
     )
     def test_api_version_not_found(self, *_):
         api = pynetbox.api(host,)
@@ -75,14 +73,14 @@ def test_api_version_not_found(self, *_):
 class ApiStatusTestCase(unittest.TestCase):
     class ResponseWithStatus:
         ok = True
+
         def json(self):
             return {
                 "netbox-version": "0.9.9",
             }
 
     @patch(
-        "requests.sessions.Session.get",
-        return_value=ResponseWithStatus(),
+        "requests.sessions.Session.get", return_value=ResponseWithStatus(),
     )
     def test_api_status(self, *_):
         api = pynetbox.api(host,)

tests/test_app.py

@@ -36,11 +36,7 @@ class AppConfigTestCase(unittest.TestCase):
         "pynetbox.core.query.Request.get",
         return_value={
             "tables": {
-                "DeviceTable": {
-                    "columns": [
-                        "name", "status", "tenant", "tags",
-                    ],
-                },
+                "DeviceTable": {"columns": ["name", "status", "tenant", "tags",],},
             },
         },
     )
@@ -70,10 +66,7 @@ def test_custom_choices(self, *_):
 
     @patch(
         "pynetbox.core.query.Request.get",
-        return_value=[{
-            "name": "test_plugin",
-            "package": "netbox_test_plugin",
-        }],
+        return_value=[{"name": "test_plugin", "package": "netbox_test_plugin",}],
     )
     def test_installed_plugins(self, *_):
         api = pynetbox.api(host, **def_kwargs)

tests/test_dcim.py

@@ -89,9 +89,7 @@ def test_delete(self):
                 return_value=Response(
                     fixture="{}/{}.json".format(self.app, self.name[:-1])
                 ),
-            ) as mock, patch(
-                "requests.sessions.Session.delete"
-            ) as delete:
+            ) as mock, patch("requests.sessions.Session.delete") as delete:
                 ret = getattr(nb, self.name).get(1)
                 self.assertTrue(ret.delete())
                 mock.assert_called_with(
@@ -531,10 +529,7 @@ def test_get_circuit(self):
                 "length_unit": None,
             }
         )
-        with patch(
-            "requests.sessions.Session.get",
-            return_value=response_obj,
-        ) as mock:
+        with patch("requests.sessions.Session.get", return_value=response_obj,) as mock:
             ret = getattr(nb, self.name).get(1)
             self.assertTrue(ret)
             self.assertTrue(isinstance(ret, self.ret))

tests/unit/test_response.py

@@ -77,20 +77,14 @@ def test_serialize_string_tag_set(self):
         self.assertEqual(len(test["tags"]), 2)
 
     def test_serialize_dict_tag_set(self):
-        test_values = {"id": 123, "tags": [
-            {
-                "id": 1,
-                "name": "foo",
-            },
-            {
-                "id": 2,
-                "name": "bar",
-            },
-            {
-                "id": 3,
-                "name": "baz",
-            },
-        ]}
+        test_values = {
+            "id": 123,
+            "tags": [
+                {"id": 1, "name": "foo",},
+                {"id": 2, "name": "bar",},
+                {"id": 3, "name": "baz",},
+            ],
+        }
         test = Record(test_values, None, None).serialize()
         self.assertEqual(len(test["tags"]), 3)