Merge pull request #549 from markkuleinio/fix-constraints

Fix permissions contraints handling in case of list of dicts (fixes #465)

Author: abhi1693

pynetbox/core/response.py

@@ -413,6 +413,9 @@ def list_parser(key_name, list_item):
                 if len(v) and isinstance(v[0], dict) and "object_type" in v[0]:
                     v = [generic_list_parser(k, i) for i in v]
                     to_cache = list(v)
+                elif k == "constraints":
+                    # Permissions constraints can be either dict or list
+                    to_cache = copy.deepcopy(v)
                 else:
                     v = [list_parser(k, i) for i in v]
                     to_cache = list(v)

tests/fixtures/users/permission.json

@@ -5,5 +5,13 @@
         {
             "username": "user1"
         }
+    ],
+    "constraints": [
+        {
+            "status": "active"
+        },
+        {
+            "region__name": "Europe"
+        }
     ]
 }

tests/test_users.py

@@ -104,6 +104,15 @@ def test_username(self, _):
         user = permission.users[0]
         self.assertEqual(str(user), "user1")
 
+    @patch(
+        "requests.sessions.Session.get",
+        return_value=Response(fixture="users/permission.json"),
+    )
+    def test_constraints(self, _):
+        permission = nb.permissions.get(1)
+        self.assertIsInstance(permission.constraints, list)
+        self.assertIsInstance(permission.constraints[0], dict)
+
 
 class UnknownModelTestCase(unittest.TestCase):
     """This test validates that an unknown model is returned as Record object