Skip to content

Commit a17f55e

Browse files
author
Zach Moody
authored
Merge pull request #261 from markkuleinio/fix-version-session
Fixes #260: Change Request.get_version() to use self.http_session
2 parents 4dd1ce7 + cc39016 commit a17f55e

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

pynetbox/core/query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def get_version(self):
197197
headers = {
198198
"Content-Type": "application/json;",
199199
}
200-
req = requests.get(self.normalize_url(self.base), headers=headers,)
200+
req = self.http_session.get(self.normalize_url(self.base), headers=headers,)
201201
if req.ok:
202202
return req.headers.get("API-Version", "")
203203
else:

tests/test_api.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ class ResponseHeadersWithVersion:
5151
headers = {"API-Version": "1.999"}
5252
ok = True
5353

54-
@patch("requests.get", return_value=ResponseHeadersWithVersion())
54+
@patch(
55+
"pynetbox.core.query.requests.sessions.Session.get",
56+
return_value=ResponseHeadersWithVersion(),
57+
)
5558
def test_api_version(self, *_):
5659
api = pynetbox.api(host,)
5760
self.assertEqual(api.version, "1.999")
@@ -60,7 +63,10 @@ class ResponseHeadersWithoutVersion:
6063
headers = {}
6164
ok = True
6265

63-
@patch("requests.get", return_value=ResponseHeadersWithoutVersion())
66+
@patch(
67+
"pynetbox.core.query.requests.sessions.Session.get",
68+
return_value=ResponseHeadersWithoutVersion(),
69+
)
6470
def test_api_version_not_found(self, *_):
6571
api = pynetbox.api(host,)
6672
self.assertEqual(api.version, "")

0 commit comments

Comments
 (0)