Skip to content

Commit 5f7cf6b

Browse files
authored
Merge pull request #1471 from maxulysse/schema
fix(schema): add some params to validationSchemaIgnoreParams for better handling
2 parents 6b7a6b4 + 7dd75ca commit 5f7cf6b

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ Balgattjåhkkå is the other top peak (over 2k m) in the Pårte massif, the othe
5959
- [#1463](https://github.com/nf-core/sarek/pull/1463) - Add `spark` profile to all gatk4spark tests
6060
- [#1465](https://github.com/nf-core/sarek/pull/1465), [#1469](https://github.com/nf-core/sarek/pull/1469) - Fix input channels and tests of Sentieon workflows
6161
- [#1470](https://github.com/nf-core/sarek/pull/1470) - Fix channels for `MultiQC`
62+
- [#1471](https://github.com/nf-core/sarek/pull/1471) - Add `snpeff_db` params to `validationSchemaIgnoreParams` to fix issues with Seqera Platform
63+
- [#1471](https://github.com/nf-core/sarek/pull/1471) - Add `vep_cache_version` params to `validationSchemaIgnoreParams` to fix [#1454](https://github.com/nf-core/sarek/issues/1454)
64+
- [#1471](https://github.com/nf-core/sarek/pull/1471) - Update `vep_version` params match the actual tool version
6265

6366
### Removed
6467

nextflow.config

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ params {
9797
vep_out_format = "vcf"
9898
vep_spliceai = null // spliceai plugin disabled within VEP
9999
vep_spliceregion = null // spliceregion plugin disabled within VEP
100-
vep_version = "110.0-0" // Should be updated when we update VEP, needs this to get full path to some plugins
100+
vep_version = "111.0-0" // Should be updated when we update VEP, needs this to get full path to some plugins
101101

102102
// MultiQC options
103103
multiqc_config = null
@@ -136,7 +136,7 @@ params {
136136
// Schema validation default options
137137
validationFailUnrecognisedParams = false
138138
validationLenientMode = true
139-
validationSchemaIgnoreParams = 'cf_ploidy,genomes,igenomes_base'
139+
validationSchemaIgnoreParams = 'cf_ploidy,snpeff_db,vep_cache_version,genomes,igenomes_base'
140140
validationShowHiddenParams = false
141141
validate_params = true
142142
}

nextflow_schema.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@
520520
},
521521
"vep_version": {
522522
"type": "string",
523-
"default": "110.0-0",
523+
"default": "111.0-0",
524524
"fa_icon": "fas fa-toolbox",
525525
"description": "Should reflect the VEP version used in the container.",
526526
"help_text": "Used by the loftee plugin that need the full path."
@@ -785,7 +785,7 @@
785785
"help_text": "If you use AWS iGenomes, this has already been set for you appropriately.\nAlternatively species listed in Ensembl Genomes caches can be used."
786786
},
787787
"vep_cache_version": {
788-
"type": "number",
788+
"type": "string",
789789
"fa_icon": "fas fa-tag",
790790
"description": "VEP cache version.",
791791
"help_text": "If you use AWS iGenomes, this has already been set for you appropriately.\nAlternatively cache version can be use to specify the correct Ensembl Genomes version number as these differ from the concurrent Ensembl/VEP version numbers"

0 commit comments

Comments
 (0)