Skip to content

Commit 1208390

Browse files
authored
Merge branch 'dev' into fix-output-detection-in-lint-3513
2 parents 8a267b9 + 083d157 commit 1208390

File tree

7 files changed

+22
-64
lines changed

7 files changed

+22
-64
lines changed

.github/workflows/create-lint-wf.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@ on:
1515
release:
1616
types: [published]
1717
workflow_dispatch:
18-
inputs:
19-
runners:
20-
description: "Runners to test on"
21-
type: choice
22-
options:
23-
- "ubuntu-latest"
24-
- "self-hosted"
25-
default: "self-hosted"
2618

2719
# Cancel if a newer run is started
2820
concurrency:
@@ -31,7 +23,9 @@ concurrency:
3123

3224
jobs:
3325
MakeTestWorkflow:
34-
runs-on: ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
26+
runs-on:
27+
- runs-on=${{ github.run_id }}-make-test-worfklow
28+
- runner=4cpu-linux-x64
3529
env:
3630
NXF_ANSI_LOG: false
3731

.github/workflows/create-test-lint-wf-template.yml

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,6 @@ on:
1414
release:
1515
types: [published]
1616
workflow_dispatch:
17-
inputs:
18-
runners:
19-
description: "Runners to test on"
20-
type: choice
21-
options:
22-
- "ubuntu-latest"
23-
- "self-hosted"
24-
default: "self-hosted"
2517

2618
# Cancel if a newer run is started
2719
concurrency:
@@ -49,28 +41,18 @@ jobs:
4941
echo "matrix=$(yq 'keys | filter(. != "github") | filter(. != "is_nfcore") | filter(. != "test_config") | tojson(0)' nf_core/pipelines/create/template_features.yml)" >> $GITHUB_OUTPUT
5042
5143
RunTestWorkflow:
52-
runs-on: ${{ matrix.runner }}
44+
runs-on:
45+
- runs-on=${{ github.run_id }}-run-test-worfklow
46+
- runner=4cpu-linux-x64
5347
needs: prepare-matrix
5448
env:
5549
NXF_ANSI_LOG: false
5650

5751
strategy:
5852
matrix:
5953
TEMPLATE: ${{ fromJson(needs.prepare-matrix.outputs.all_features) }}
60-
runner:
61-
# use the runner given by the input if it is dispatched manually, run on github if it is a rerun or on self-hosted by default
62-
- ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
63-
profile: ["self_hosted_runner"]
6454
include:
6555
- TEMPLATE: all
66-
runner: ubuntu-latest
67-
profile: "docker"
68-
- TEMPLATE: nf_core_configs
69-
runner: ubuntu-latest
70-
profile: "docker"
71-
exclude:
72-
- TEMPLATE: nf_core_configs
73-
profile: "self_hosted_runner"
7456
fail-fast: false
7557

7658
steps:
@@ -119,7 +101,7 @@ jobs:
119101
- name: run the pipeline
120102
run: |
121103
cd create-test-lint-wf
122-
nextflow run my-prefix-testpipeline -profile test,${{matrix.profile}} --outdir ./results
104+
nextflow run my-prefix-testpipeline -profile test,docker --outdir ./results
123105
124106
# Remove results folder before linting
125107
- name: remove results folder

.github/workflows/create-test-wf.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@ on:
1515
release:
1616
types: [published]
1717
workflow_dispatch:
18-
inputs:
19-
runners:
20-
description: "Runners to test on"
21-
type: choice
22-
options:
23-
- "ubuntu-latest"
24-
- "self-hosted"
25-
default: "self-hosted"
2618

2719
# Cancel if a newer run is started
2820
concurrency:
@@ -31,8 +23,9 @@ concurrency:
3123

3224
jobs:
3325
RunTestWorkflow:
34-
# use the runner given by the input if it is dispatched manually, run on github if it is a rerun or on self-hosted by default
35-
runs-on: ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
26+
runs-on:
27+
- runs-on=${{ github.run_id }}-run-test-worfklow
28+
- runner=4cpu-linux-x64
3629
env:
3730
NXF_ANSI_LOG: false
3831

@@ -71,7 +64,7 @@ jobs:
7164
mkdir create-test-wf && cd create-test-wf
7265
export NXF_WORK=$(pwd)
7366
nf-core --log-file log.txt pipelines create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface"
74-
nextflow run nf-core-testpipeline -profile self_hosted_runner,test --outdir ./results
67+
nextflow run nf-core-testpipeline -profile docker,test --outdir ./results
7568
7669
- name: Upload log file artifact
7770
if: ${{ always() }}

.github/workflows/pytest.yml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ on:
2020
release:
2121
types: [published]
2222
workflow_dispatch:
23-
inputs:
24-
runners:
25-
description: "Runners to test on"
26-
type: choice
27-
options:
28-
- "ubuntu-latest"
29-
- "self-hosted"
30-
default: "self-hosted"
3123

3224
# Cancel if a newer run with the same workflow name is queued
3325
concurrency:
@@ -77,8 +69,9 @@ jobs:
7769
name: Run ${{matrix.test}} with Python ${{ needs.setup.outputs.python-version }} on ${{ needs.setup.outputs.runner }}
7870
needs: [setup, list_tests]
7971
if: ${{ needs.setup.outputs.run-tests }}
80-
# run on self-hosted runners for test_components_generate_snapshot.py (because of the gitlab branch), based on the input if it is dispatched manually, on github if it is a rerun or on self-hosted by default
81-
runs-on: ${{ matrix.test == 'components/test_components_generate_snapshot.py' && 'self-hosted' || (github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted') }}
72+
runs-on:
73+
- runs-on=${{ github.run_id }}-run-test
74+
- runner=4cpu-linux-x64
8275
strategy:
8376
matrix: ${{ fromJson(needs.list_tests.outputs.tests) }}
8477
fail-fast: false # run all tests even if one fails
@@ -166,8 +159,9 @@ jobs:
166159

167160
coverage:
168161
needs: test
169-
# use the runner given by the input if it is dispatched manually, run on github if it is a rerun or on self-hosted by default
170-
runs-on: ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
162+
runs-on:
163+
- runs-on=${{ github.run_id }}-coverage
164+
- runner=2cpu-linux-x64
171165
steps:
172166
- name: go to subdirectory
173167
run: |

.github/workflows/sync.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,6 @@ on:
88
type: boolean
99
description: Only run on nf-core/testpipeline?
1010
required: true
11-
runners:
12-
description: "Runners to test on"
13-
type: choice
14-
options:
15-
- "ubuntu-latest"
16-
- "self-hosted"
17-
default: "self-hosted"
1811
force_pr:
1912
description: "Force a PR to be created"
2013
type: boolean
@@ -58,8 +51,9 @@ jobs:
5851
5952
sync:
6053
needs: get-pipelines
61-
# use the github runner on release otherwise use the runner given by the input if it is dispatched manually, run on github if it is a rerun or on self-hosted by default
62-
runs-on: ${{github.event_name == 'release' && 'self-hosted' || github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
54+
runs-on:
55+
- runs-on=${{ github.run_id }}-sync
56+
- runner=4cpu-linux-x64
6357
strategy:
6458
matrix: ${{fromJson(needs.get-pipelines.outputs.matrix)}}
6559
fail-fast: false

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
- Fix indentation in included_configs API docs ([#3523](https://github.com/nf-core/tools/pull/3523))
6262
- chore(deps): update python:3.12-slim docker digest to a866731 ([#3527](https://github.com/nf-core/tools/pull/3527))
6363
- adding boundary in regex ([#3535](https://github.com/nf-core/tools/pull/3535))
64+
- switch to using runsOn runners in nf-core/tools repo ([#3537](https://github.com/nf-core/tools/pull/3537))
6465

6566
## [v3.2.0 - Pewter Pangolin](https://github.com/nf-core/tools/releases/tag/3.2.0) - [2025-01-27]
6667

tests/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
GITLAB_BRANCH_ORG_PATH_BRANCH = "org-path"
3333
GITLAB_BRANCH_TEST_OLD_SHA = "e772abc22c1ff26afdf377845c323172fb3c19ca"
3434
GITLAB_BRANCH_TEST_NEW_SHA = "7d73e21f30041297ea44367f2b4fd4e045c0b991"
35-
GITLAB_NFTEST_BRANCH = "nf-test-tests-self-hosted-runners"
35+
GITLAB_NFTEST_BRANCH = "nf-test-tests"
3636

3737

3838
def with_temporary_folder(func: Callable[..., Any]) -> Callable[..., Any]:

0 commit comments

Comments
 (0)