Skip to content

DirtyCheckGuard trigger confirmChanges on undefined isDirty$ #38

@remi-bouguermouh-eaton

Description

@remi-bouguermouh-eaton

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

When guard is put on a route and a component without isDirty$ implementation the guard triggers the confirmChanges method. I'm not sure if this is a desired behavior.

Minimal reproduction of the problem with instructions

Put the Guard on a route with a component that doesn't implement the isDirty$ property.

What is the motivation / use case for changing the behavior?

It would make sense to not have the confirmChanges triggers.

I can put a proposal if needed.

Best regards,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions