Observer - ObserverSubjectTrait - ObserverStorage Anwendung und UnitTests

Author: andreas-maurer

src/Observer/ObserverSubjectTrait.php

@@ -8,14 +8,12 @@
 namespace NiceshopsDev\NiceCore\Observer;
 
 
-use Generator;
 use NiceshopsDev\NiceCore\Composite\AbstractComposite;
 use SplObserver;
 
 /**
  * Trait ObserverSubjectTrait
  * @package NiceshopsDev\NiceCore\Observer
- * @todo UnitTests
  */
 trait ObserverSubjectTrait
 {
@@ -29,41 +27,7 @@ trait ObserverSubjectTrait
     private function getObserverStorage()
     {
         if (!$this->observerStorage) {
-            $this->observerStorage = new class extends AbstractComposite {
-                
-                
-                /**
-                 * @param SplObserver $observer
-                 *
-                 * @return AbstractComposite
-                 */
-                public function addObserver(SplObserver $observer)
-                {
-                    return $this->addComponent($observer);
-                }
-                
-                
-                /**
-                 * @param SplObserver $observer
-                 *
-                 * @return AbstractComposite
-                 */
-                public function removeObserver(SplObserver $observer)
-                {
-                    return $this->removeComponent($observer);
-                }
-                
-                
-                /**
-                 * @return Generator   for all \SplObserver instances
-                 */
-                public function runObserver()
-                {
-                    foreach ($this->getComponent_List() as $observer) {
-                        yield $observer;
-                    }
-                }
-            };
+            $this->observerStorage = new ObserverStorage();
         }
 
         return $this->observerStorage;

test/Observer/ObserverSubjectTraitTest.php

@@ -9,6 +9,8 @@
 
 use NiceshopsDev\NiceCore\PHPUnit\DefaultTestCase;
 use PHPUnit\Framework\MockObject\MockObject;
+use SplObserver;
+use SplSubject;
 
 /**
  * UnitTest class for TraversableRunner
@@ -55,4 +57,95 @@ public function testTestClassExists()
         $this->assertUseTrait(ObserverSubjectTrait::class, $this->object, "Mock Object uses " . ObserverSubjectTrait::class);
     }
 
+    
+    /**
+     * @group  unit
+     * @small
+     *
+     * @covers ObserverSubjectTrait::getObserverStorage
+     */
+    public function testGetObserverStorage()
+    {
+        $observerStorage = $this->invokeMethod($this->object, "getObserverStorage");
+        $this->assertInstanceOf(ObserverStorage::class, $observerStorage);
+        $this->assertSame($observerStorage, $this->invokeMethod($this->object, "getObserverStorage"));
+    }
+    
+    
+    /**
+     * @group  unit
+     * @small
+     *
+     * @covers ObserverSubjectTrait::attach
+     */
+    public function testAttach()
+    {
+        $observerStorage = $this->getMockBuilder(ObserverStorage::class)->disableOriginalConstructor()->setMethods(["addObserver"])->getMock();
+        
+        /**
+         * @var SplObserver $observer
+         */
+        $observer = $this->getMockBuilder(SplObserver::class)->getMock();
+        
+        $this->invokeSetProperty($this->object, "observerStorage", $observerStorage);
+        $observerStorage->expects($this->once())->method("addObserver")->with(...[$observer]);
+        
+        $this->assertSame($this->object, $this->object->attach($observer));
+    }
+    
+    
+    /**
+     * @group  unit
+     * @small
+     *
+     * @covers ObserverSubjectTrait::c
+     */
+    public function testDetach()
+    {
+        $observerStorage = $this->getMockBuilder(ObserverStorage::class)->disableOriginalConstructor()->setMethods(["removeObserver"])->getMock();
+        
+        /**
+         * @var SplObserver|MockObject $observer
+         */
+        $observer = $this->getMockBuilder(SplObserver::class)->getMock();
+        
+        $this->invokeSetProperty($this->object, "observerStorage", $observerStorage);
+        $observerStorage->expects($this->once())->method("removeObserver")->with(...[$observer]);
+        
+        $this->assertSame($this->object, $this->object->detach($observer));
+    }
+    
+    
+    /**
+     * @group  unit
+     * @small
+     *
+     * @covers ObserverSubjectTrait::notify
+     */
+    public function testNotify()
+    {
+        $observerStorage = $this->getMockBuilder(ObserverStorage::class)->disableOriginalConstructor()->setMethods(["runObserver"])->getMock();
+        
+        $this->object = new class implements SplSubject {
+            use ObserverSubjectTrait;
+        };
+        $this->invokeSetProperty($this->object, "observerStorage", $observerStorage);
+        
+        /**
+         * @var SplObserver[]|MockObject[] $arrObserver
+         */
+        $arrObserver = [
+            $this->getMockBuilder(SplObserver::class)->setMethods(["update"])->getMock(),
+            $this->getMockBuilder(SplObserver::class)->setMethods(["update"])->getMock(),
+            $this->getMockBuilder(SplObserver::class)->setMethods(["update"])->getMock(),
+        ];
+        
+        foreach ($arrObserver as $observer) {
+            $observer->expects($this->once())->method("update")->with(...[$this->object]);
+        }
+        
+        $observerStorage->expects($this->once())->method("runObserver")->willReturn($arrObserver);
+        
+        $this->assertSame($this->object, $this->object->notify());
+    }
 }