🧪 test: improve test

Author: nmdra

internal/embed/embed_test.go

@@ -8,7 +8,6 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-// Ensure MockEmbedder satisfies the Embedder interface
 var _ Embedder = (*MockEmbedder)(nil)
 
 type MockEmbedder struct {
@@ -20,28 +19,57 @@ func (m *MockEmbedder) Embed(ctx context.Context, input string) ([]float32, erro
 	return m.Response, m.Err
 }
 
-func TestMockEmbedder_Success(t *testing.T) {
-	mock := &MockEmbedder{
-		Response: make([]float32, 768),
-	}
+func TestMockEmbedder(t *testing.T) {
+	t.Run("Success", func(t *testing.T) {
+		mock := &MockEmbedder{
+			Response: make([]float32, 768),
+		}
 
-	ctx := context.Background()
-	input := "test input"
-	result, err := mock.Embed(ctx, input)
+		ctx := context.Background()
+		input := "test input"
+
+		result, err := mock.Embed(ctx, input)
+
+		assert.NoError(t, err, "expected no error on successful embed")
+		assert.NotNil(t, result, "expected a non-nil result")
+		assert.Equal(t, 768, len(result), "expected result to have 768 dimensions")
+	})
+
+	t.Run("Error", func(t *testing.T) {
+		expectedErr := errors.New("mock error")
+		mock := &MockEmbedder{
+			Err: expectedErr,
+		}
 
-	assert.NoError(t, err, "expected no error on successful embed")
-	assert.NotNil(t, result, "expected a non-nil result")
-	assert.Equal(t, 768, len(result), "expected result to have 768 dimensions")
+		ctx := context.Background()
+		result, err := mock.Embed(ctx, "fail case")
+
+		assert.Error(t, err, "expected an error on embed failure")
+		assert.ErrorIs(t, err, expectedErr, "error should match mock error")
+		assert.Nil(t, result, "expected result to be nil on error")
+	})
+
+	t.Run("Empty input", func(t *testing.T) {
+		mock := &MockEmbedder{
+			Response: make([]float32, 768),
+		}
+
+		ctx := context.Background()
+		result, err := mock.Embed(ctx, "")
+
+		assert.NoError(t, err, "expected no error on empty input")
+		assert.NotNil(t, result, "expected result even with empty input")
+		assert.Equal(t, 768, len(result), "expected result to have 768 dimensions")
+	})
 }
 
-func TestMockEmbedder_Error(t *testing.T) {
+func BenchmarkMockEmbedder(b *testing.B) {
 	mock := &MockEmbedder{
-		Err: errors.New("mock error"),
+		Response: make([]float32, 768),
 	}
 
 	ctx := context.Background()
-	result, err := mock.Embed(ctx, "fail case")
-
-	assert.Error(t, err, "expected an error on embed failure")
-	assert.Nil(t, result, "expected result to be nil on error")
+	for i := 0; i < b.N; i++ {
+		_, _ = mock.Embed(ctx, "benchmark input")
+	}
 }