Skip to content

Commit 72c3fb1

Browse files
committed
stop trying to build with clang on windows
we've never actually used clang before on windows, nodejs recently started supporting clang on windows, but node_gyp is still not fully compatible and tries to enable LTCG in a way that clang doesn't recognize
1 parent 27b0cc3 commit 72c3fb1

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.github/workflows/rebuildElectron.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,6 @@ jobs:
110110
node_pre_gyp_bucket: ${{ secrets.node_pre_gyp_bucket }}
111111
AWS_ACCESS_KEY_ID: ${{ secrets.node_pre_gyp_accessKeyId }}
112112
AWS_SECRET_ACCESS_KEY: ${{ secrets.node_pre_gyp_secretAccessKey }}
113-
CC: clang
114-
CXX: clang++
115-
npm_config_clang: 1
116113
GYP_DEFINES: use_obsolete_asm=true
117114
BUILD_ONLY: true
118115
electron_npg_automator_module: nodegit/nodegit
@@ -123,9 +120,6 @@ jobs:
123120
node_pre_gyp_bucket: ${{ secrets.node_pre_gyp_bucket }}
124121
AWS_ACCESS_KEY_ID: ${{ secrets.node_pre_gyp_accessKeyId }}
125122
AWS_SECRET_ACCESS_KEY: ${{ secrets.node_pre_gyp_secretAccessKey }}
126-
CC: clang
127-
CXX: clang++
128-
npm_config_clang: 1
129123
GYP_DEFINES: use_obsolete_asm=true
130124
BUILD_ONLY: true
131125
electron_npg_automator_module: nodegit/nodegit
@@ -136,9 +130,6 @@ jobs:
136130
node_pre_gyp_bucket: ${{ secrets.node_pre_gyp_bucket }}
137131
AWS_ACCESS_KEY_ID: ${{ secrets.node_pre_gyp_accessKeyId }}
138132
AWS_SECRET_ACCESS_KEY: ${{ secrets.node_pre_gyp_secretAccessKey }}
139-
CC: clang
140-
CXX: clang++
141-
npm_config_clang: 1
142133
GYP_DEFINES: use_obsolete_asm=true
143134
BUILD_ONLY: true
144135
electron_npg_automator_module: nodegit/nodegit

0 commit comments

Comments
 (0)