AWS nacl analysis (#732)

* move nacl analysis to common pkg

* support aws nacl analysis

* handle tcp udp and icmp potocol numbers

* handle resources names in aws
---------

Co-authored-by: haim-kermany <82028281+haim-kermany@users.noreply.github.com>

Author: olasaadi99

cmd/analyzer/main_test.go

@@ -30,6 +30,10 @@ func TestMain(t *testing.T) {
 			name: "aws_all_endpoints",
 			args: "report endpoints -f aws.txt -c ../../pkg/awsvpc/examples/input/input_basic_config_with_sg.json -o txt",
 		},
+		{
+			name: "aws_all_subnets",
+			args: "report subnets -f aws.txt -c ../../pkg/awsvpc/examples/input/input_aws_acl_1.json -o txt",
+		},
 		// drawio
 		{
 			name: "drawio_multi_vpc_all_subnets",

go.mod

@@ -5,6 +5,7 @@ go 1.22.4
 require (
 	github.com/IBM/networking-go-sdk v0.49.0
 	github.com/IBM/vpc-go-sdk v0.54.0
+	github.com/aws/aws-sdk-go-v2/service/ec2 v1.163.0
 	github.com/np-guard/cloud-resource-collector v0.13.0
 	github.com/np-guard/models v0.3.4
 	github.com/spf13/cobra v1.8.1
@@ -23,7 +24,6 @@ require (
 	github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.12 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.12 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/ini v1.8.0 // indirect
-	github.com/aws/aws-sdk-go-v2/service/ec2 v1.163.0 // indirect
 	github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.2 // indirect
 	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.14 // indirect
 	github.com/aws/aws-sdk-go-v2/service/sso v1.21.1 // indirect

pkg/awsvpc/analysis_output_test.go

@@ -193,19 +193,24 @@ func (tt *vpcGeneralTest) initTest() {
 var tests = []*vpcGeneralTest{
 	{
 		inputConfig: "basic_config_with_sg",
-		useCases:    []vpcmodel.OutputUseCase{vpcmodel.AllEndpoints},
+		useCases:    []vpcmodel.OutputUseCase{vpcmodel.AllEndpoints, vpcmodel.AllSubnets},
 		format:      vpcmodel.Text,
 	},
 	{
 		inputConfig: "aws_sg_1",
-		useCases:    []vpcmodel.OutputUseCase{vpcmodel.AllEndpoints},
+		useCases:    []vpcmodel.OutputUseCase{vpcmodel.AllEndpoints, vpcmodel.AllSubnets},
 		format:      vpcmodel.Text,
 	},
 	{
 		inputConfig: "aws_sg_1",
 		useCases:    []vpcmodel.OutputUseCase{vpcmodel.AllEndpoints},
 		format:      vpcmodel.HTML,
 	},
+	{
+		inputConfig: "aws_acl_1",
+		useCases:    []vpcmodel.OutputUseCase{vpcmodel.AllEndpoints, vpcmodel.AllSubnets},
+		format:      vpcmodel.Text,
+	},
 }
 
 var formatsAvoidComparison = map[vpcmodel.OutFormat]bool{