CR

Author: ShiriMoran

pkg/linter/lintFilterRuleSplitSubnet.go

@@ -41,8 +41,7 @@ func (lint *filterRuleSplitSubnet) lintDescription() string {
 	return "Firewall rules implying different connectivity for different endpoints within a subnet"
 }
 
-func (lint *filterRuleSplitSubnet) check() (bool, error) {
-	lintOK := true
+func (lint *filterRuleSplitSubnet) check() ([]finding, error) {
 	findingRes := []*splitRuleSubnet{}
 	for _, config := range lint.configs {
 		if config.IsMultipleVPCsConfig {
@@ -52,17 +51,16 @@ func (lint *filterRuleSplitSubnet) check() (bool, error) {
 			filterLayer := config.GetFilterTrafficResourceOfKind(layer)
 			rules, err := filterLayer.GetRules()
 			if err != nil {
-				return false, err
+				return nil, err
 			}
 			for _, rule := range rules {
 				subnetsSplitByRule := []vpcmodel.Subnet{}
 				for _, subnet := range config.Subnets {
 					splitSubnet, err := ruleSplitSubnet(subnet, rule.IPBlocks)
 					if err != nil {
-						return false, err
+						return nil, err
 					}
 					if splitSubnet {
-						lintOK = false
 						subnetsSplitByRule = append(subnetsSplitByRule, subnet)
 					}
 				}
@@ -74,7 +72,7 @@ func (lint *filterRuleSplitSubnet) check() (bool, error) {
 		}
 	}
 	lint.findings = findingRes
-	return lintOK, nil
+	return lint.convertToFindings(), nil
 }
 
 func (lint *filterRuleSplitSubnet) string() string {
@@ -103,7 +101,8 @@ func ruleSplitSubnet(subnet vpcmodel.Subnet, ruleIPBlocks []*ipblock.IPBlock) (b
 	return false, nil
 }
 
-func (lint *filterRuleSplitSubnet) getFindings() []finding {
+// todo: is there a better way?
+func (lint *filterRuleSplitSubnet) convertToFindings() []finding {
 	resFinding := make([]finding, len(lint.findings))
 	for i, issue := range lint.findings {
 		resFinding[i] = issue

pkg/linter/linterExecute.go

@@ -28,11 +28,11 @@ func LinterExecute(configs map[string]*vpcmodel.VPCConfig) (issueFound bool, res
 	strPerLint := []string{}
 	for _, thisLinter := range linters {
 		thisLintStr := ""
-		lintOK, err := thisLinter.check()
+		lintFindings, err := thisLinter.check()
 		if err != nil {
 			return false, "", err
 		}
-		if lintOK {
+		if len(lintFindings) == 0 {
 			thisLintStr = fmt.Sprintf("no lint %q issues\n", thisLinter.lintDescription())
 		} else {
 			issueFound = true

pkg/linter/linterTypes.go

@@ -10,12 +10,11 @@ import "github.com/np-guard/vpc-network-config-analyzer/pkg/vpcmodel"
 
 // todo: export certain functionality
 type linter interface {
-	check() (bool, error)    // false if issues found
-	lintName() string        // this lint Name
-	lintDescription() string // this string Name
-	string() string          // string with this lint's finding
-	toJSON() []any           // this lint finding in JSON
-	getFindings() []finding
+	check() ([]finding, error) // false if issues found
+	lintName() string          // this lint Name
+	lintDescription() string   // this string Name
+	string() string            // string with this lint's finding
+	toJSON() []any             // this lint finding in JSON
 }
 
 type finding interface {