Skip to content

Commit b152050

Browse files
olasaadi99olasaadi99
committed
remove ExtendedName() method
1 parent ded85a8 commit b152050

21 files changed

+124
-152
lines changed

‎pkg/awsvpc/parser.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -446,15 +446,15 @@ func printConfig(c *vpcmodel.VPCConfig) {
446446
if n.IsExternal() {
447447
continue
448448
}
449-
logging.Debug(strings.Join([]string{n.Kind(), n.CidrOrAddress(), n.NameForAnalyzerOut(), n.UID()}, separator))
449+
logging.Debug(strings.Join([]string{n.Kind(), n.CidrOrAddress(), n.NameForAnalyzerOut(nil), n.UID()}, separator))
450450
}
451451
logging.Debug("Subnets:")
452452
for _, n := range c.Subnets {
453-
logging.Debug(strings.Join([]string{n.Kind(), n.CIDR(), n.NameForAnalyzerOut(), n.UID()}, separator))
453+
logging.Debug(strings.Join([]string{n.Kind(), n.CIDR(), n.NameForAnalyzerOut(nil), n.UID()}, separator))
454454
}
455455
logging.Debug("NodeSets:")
456456
for _, n := range c.NodeSets {
457-
logging.Debug(strings.Join([]string{n.Kind(), n.AddressRange().ToIPRanges(), n.NameForAnalyzerOut(), n.UID()}, separator))
457+
logging.Debug(strings.Join([]string{n.Kind(), n.AddressRange().ToIPRanges(), n.NameForAnalyzerOut(nil), n.UID()}, separator))
458458
}
459459
logging.Debug("FilterResources:")
460460
for _, f := range c.FilterResources {

‎pkg/commonvpc/vpc.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,12 @@ func (ni *NetworkInterface) VsiName() string {
9090
return ni.Vsi
9191
}
9292

93-
func (ni *NetworkInterface) NameForAnalyzerOut() string {
94-
return nameWithBracketsInfo(ni.Vsi, ni.Address())
95-
}
96-
97-
func (ni *NetworkInterface) ExtendedName(c *vpcmodel.VPCConfig) string {
93+
func (ni *NetworkInterface) NameForAnalyzerOut(c *vpcmodel.VPCConfig) string {
9894
prefix := ""
99-
if c.IsMultipleVPCsConfig {
95+
if c != nil && c.IsMultipleVPCsConfig {
10096
prefix = ni.VPC().Name() + vpcmodel.Deliminator
10197
}
102-
return prefix + ni.NameForAnalyzerOut()
98+
return prefix + nameWithBracketsInfo(ni.Vsi, ni.Address())
10399
}
104100

105101
func nameWithBracketsInfo(name, inBrackets string) string {

‎pkg/ibmvpc/parser.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1517,19 +1517,19 @@ func printConfig(c *vpcmodel.VPCConfig) {
15171517
if n.IsExternal() {
15181518
continue
15191519
}
1520-
logging.Debug(strings.Join([]string{n.Kind(), n.CidrOrAddress(), n.NameForAnalyzerOut(), n.UID()}, separator))
1520+
logging.Debug(strings.Join([]string{n.Kind(), n.CidrOrAddress(), n.NameForAnalyzerOut(nil), n.UID()}, separator))
15211521
}
15221522
logging.Debug("Subnets:")
15231523
for _, n := range c.Subnets {
1524-
logging.Debug(strings.Join([]string{n.Kind(), n.CIDR(), n.NameForAnalyzerOut(), n.UID()}, separator))
1524+
logging.Debug(strings.Join([]string{n.Kind(), n.CIDR(), n.NameForAnalyzerOut(nil), n.UID()}, separator))
15251525
}
15261526
logging.Debug("LoadBalancers:")
15271527
for _, lb := range c.LoadBalancers {
1528-
logging.Debug(strings.Join([]string{lb.Kind(), lb.NameForAnalyzerOut(), lb.AddressRange().ToIPRanges(), lb.UID()}, separator))
1528+
logging.Debug(strings.Join([]string{lb.Kind(), lb.NameForAnalyzerOut(nil), lb.AddressRange().ToIPRanges(), lb.UID()}, separator))
15291529
}
15301530
logging.Debug("NodeSets:")
15311531
for _, n := range c.NodeSets {
1532-
logging.Debug(strings.Join([]string{n.Kind(), n.AddressRange().ToIPRanges(), n.NameForAnalyzerOut(), n.UID()}, separator))
1532+
logging.Debug(strings.Join([]string{n.Kind(), n.AddressRange().ToIPRanges(), n.NameForAnalyzerOut(nil), n.UID()}, separator))
15331533
}
15341534
logging.Debug("FilterResources:")
15351535
for _, f := range c.FilterResources {
@@ -1554,14 +1554,14 @@ func printConfig(c *vpcmodel.VPCConfig) {
15541554
}
15551555
logging.Debug("RoutingResources:")
15561556
for _, r := range c.RoutingResources {
1557-
logging.Debug(strings.Join([]string{r.Kind(), r.NameForAnalyzerOut(), r.UID()}, separator))
1557+
logging.Debug(strings.Join([]string{r.Kind(), r.NameForAnalyzerOut(nil), r.UID()}, separator))
15581558
if tgw, ok := r.(*TransitGateway); ok {
15591559
printTGWAvailableRoutes(tgw)
15601560
}
15611561
}
15621562
logging.Debug("RoutingTables:")
15631563
for _, r := range c.RoutingTables {
1564-
logging.Debug(strings.Join([]string{r.Kind(), r.NameForAnalyzerOut(), r.UID(), "vpc:", r.VPC().UID()}, separator))
1564+
logging.Debug(strings.Join([]string{r.Kind(), r.NameForAnalyzerOut(nil), r.UID(), "vpc:", r.VPC().UID()}, separator))
15651565
if rt, ok := r.(*ingressRoutingTable); ok {
15661566
logging.Debug("ingress routing table")
15671567
logging.Debug(rt.string())
@@ -1572,7 +1572,7 @@ func printConfig(c *vpcmodel.VPCConfig) {
15721572
logging.Debug("subnets:")
15731573
subnetsList := make([]string, len(rt.subnets))
15741574
for i := range rt.subnets {
1575-
subnetsList[i] = rt.subnets[i].NameForAnalyzerOut()
1575+
subnetsList[i] = rt.subnets[i].NameForAnalyzerOut(nil)
15761576
}
15771577
logging.Debug(strings.Join(subnetsList, ","))
15781578
}

‎pkg/ibmvpc/vpc.go

Lines changed: 19 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,17 @@ type ReservedIP struct {
3737
vpe string
3838
}
3939

40-
func (r *ReservedIP) NameForAnalyzerOut() string {
41-
return nameWithBracketsInfo(r.vpe, r.Address())
42-
}
43-
44-
func (r *ReservedIP) ExtendedName(c *vpcmodel.VPCConfig) string {
40+
func (r *ReservedIP) NameForAnalyzerOut(c *vpcmodel.VPCConfig) string {
4541
prefix := ""
46-
if c.IsMultipleVPCsConfig {
42+
if c != nil && c.IsMultipleVPCsConfig {
4743
prefix = r.VPC().Name() + vpcmodel.Deliminator
4844
}
49-
return prefix + r.NameForAnalyzerOut()
45+
return prefix + nameWithBracketsInfo(r.vpe, r.Address())
5046
}
5147

5248
// used for synthesis output
5349
func (r *ReservedIP) SynthesisResourceName() string {
54-
return r.VPC().NameForAnalyzerOut() + vpcmodel.Deliminator + r.vpe
50+
return r.VPC().Name() + vpcmodel.Deliminator + r.vpe
5551
}
5652

5753
func (r *ReservedIP) SynthesisKind() spec.ResourceType {
@@ -70,24 +66,21 @@ type PrivateIP struct {
7066
block *ipblock.IPBlock
7167
}
7268

73-
func (pip *PrivateIP) NameForAnalyzerOut() string {
69+
func (pip *PrivateIP) NameForAnalyzerOut(c *vpcmodel.VPCConfig) string {
70+
prefix := ""
71+
if c != nil && c.IsMultipleVPCsConfig {
72+
prefix = pip.VPC().Name() + vpcmodel.Deliminator
73+
}
74+
7475
kind := "LB private IP"
7576
address := pip.Address()
7677
if !pip.original {
7778
kind = "Potential " + kind
7879
// todo - use ToRangesListString() instead of ListToPrint()
7980
address = strings.Join(pip.block.ListToPrint(), ",")
8081
}
81-
name := nameWithBracketsInfo(pip.loadBalancer.NameForAnalyzerOut(), kind)
82-
return nameWithBracketsInfo(name, address)
83-
}
84-
85-
func (pip *PrivateIP) ExtendedName(c *vpcmodel.VPCConfig) string {
86-
prefix := ""
87-
if c.IsMultipleVPCsConfig {
88-
prefix = pip.VPC().Name() + vpcmodel.Deliminator
89-
}
90-
return prefix + pip.NameForAnalyzerOut()
82+
name := nameWithBracketsInfo(pip.loadBalancer.Name(), kind)
83+
return prefix + nameWithBracketsInfo(name, address)
9184
}
9285

9386
// AbstractedToNodeSet returns the pip load balancer if it was abstracted
@@ -111,16 +104,12 @@ func (n *IKSNode) VsiName() string {
111104
return ""
112105
}
113106

114-
func (n *IKSNode) NameForAnalyzerOut() string {
115-
return nameWithBracketsInfo(n.Name(), n.Address())
116-
}
117-
118-
func (n *IKSNode) ExtendedName(c *vpcmodel.VPCConfig) string {
107+
func (n *IKSNode) NameForAnalyzerOut(c *vpcmodel.VPCConfig) string {
119108
prefix := ""
120-
if c.IsMultipleVPCsConfig {
109+
if c != nil && c.IsMultipleVPCsConfig {
121110
prefix = n.VPC().Name() + vpcmodel.Deliminator
122111
}
123-
return prefix + n.NameForAnalyzerOut()
112+
return prefix + nameWithBracketsInfo(n.Name(), n.Address())
124113
}
125114

126115
// vpe can be in multiple zones - depending on the zones of its network interfaces..
@@ -173,9 +162,9 @@ type LoadBalancer struct {
173162
func (lb *LoadBalancer) nameWithKind() string {
174163
return nameWithBracketsInfo(lb.ResourceName, lb.Kind())
175164
}
176-
func (lb *LoadBalancer) ExtendedName(c *vpcmodel.VPCConfig) string {
165+
func (lb *LoadBalancer) NameForAnalyzerOut(c *vpcmodel.VPCConfig) string {
177166
prefix := ""
178-
if c.IsMultipleVPCsConfig {
167+
if c != nil && c.IsMultipleVPCsConfig {
179168
prefix = lb.VPC().Name() + vpcmodel.Deliminator
180169
}
181170
return prefix + lb.nameWithKind()
@@ -248,10 +237,10 @@ func (lbr *LoadBalancerRule) IsIngress() bool {
248237
func (lbr *LoadBalancerRule) String(detail bool) string {
249238
if lbr.Deny(false) {
250239
return fmt.Sprintf("%s will not connect to %s, since it is not its pool member\n",
251-
lbr.lb.nameWithKind(), lbr.dst.NameForAnalyzerOut())
240+
lbr.lb.nameWithKind(), lbr.dst.NameForAnalyzerOut(nil))
252241
}
253242
return fmt.Sprintf("%s may initiate a connection to %s, which is one of its pool members\n",
254-
lbr.lb.nameWithKind(), lbr.dst.NameForAnalyzerOut())
243+
lbr.lb.nameWithKind(), lbr.dst.NameForAnalyzerOut(nil))
255244
}
256245

257246
// routing resource elements

‎pkg/linter/lintTCPReposnseBlocked.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func (finding *blockedTCPResponseConn) string() string {
7676
vpcSrcName := finding.getVpcName(0)
7777
vpcDstName := finding.getVpcName(1)
7878
srcToDstStr := fmt.Sprintf("from \"%v%s\" to \"%v%s\"",
79-
vpcSrcName, finding.src.NameForAnalyzerOut(), vpcDstName, finding.dst.NameForAnalyzerOut())
79+
vpcSrcName, finding.src.NameForAnalyzerOut(nil), vpcDstName, finding.dst.NameForAnalyzerOut(nil))
8080

8181
return fmt.Sprintf("In the connection %s %s response is blocked", srcToDstStr,
8282
strings.ReplaceAll(finding.tcpRspDisable.String(), "protocol: ", ""))
@@ -99,7 +99,7 @@ type blockedTCPResponseConnJSON struct {
9999
func (finding *blockedTCPResponseConn) toJSON() any {
100100
vpcSrcName := finding.vpc()[0].Name()
101101
vpcDstName := finding.vpc()[1].Name()
102-
res := blockedTCPResponseConnJSON{Src: vpcSrcName + deliminator + finding.src.NameForAnalyzerOut(),
103-
Dst: vpcDstName + deliminator + finding.dst.NameForAnalyzerOut(), TCPRspDisable: connection.ToJSON(finding.tcpRspDisable)}
102+
res := blockedTCPResponseConnJSON{Src: vpcSrcName + deliminator + finding.src.NameForAnalyzerOut(nil),
103+
Dst: vpcDstName + deliminator + finding.dst.NameForAnalyzerOut(nil), TCPRspDisable: connection.ToJSON(finding.tcpRspDisable)}
104104
return res
105105
}

‎pkg/vpcmodel/abstractVPC.go

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ const (
2121
type VPCResourceIntf interface {
2222
UID() string
2323
Name() string
24-
NameForAnalyzerOut() string
25-
// ExtendedName returns a resource name that includes its VPC as prefix when necessary.
24+
// NameForAnalyzerOut returns a string to be printed for output
25+
// when config file is passed to the method it returns a resource name that
26+
// includes its VPC as prefix when necessary.
2627
// for example, a subnet with name "s1" within VPC "v1" will have extended name: "v1/s1"
27-
// note this method is relevant only for Node and Subnet objects.
2828
// note it adds the prefix only for input config that has multiple VPCs context.
29-
ExtendedName(*VPCConfig) string
29+
NameForAnalyzerOut(*VPCConfig) string
3030
ZoneName() string
3131
Kind() string
3232
VPC() VPCResourceIntf // the VPC to which this resource belongs to
@@ -51,10 +51,6 @@ func (n *VPCResource) Name() string {
5151
return n.ResourceName
5252
}
5353

54-
func (n *VPCResource) NameForAnalyzerOut() string {
55-
return n.ResourceName
56-
}
57-
5854
func (n *VPCResource) SynthesisResourceName() string {
5955
return n.VPC().Name() + Deliminator + n.ResourceName
6056
}
@@ -63,12 +59,12 @@ func (n *VPCResource) SynthesisKind() spec.ResourceType {
6359
return ""
6460
}
6561

66-
func (n *VPCResource) ExtendedName(c *VPCConfig) string {
62+
func (n *VPCResource) NameForAnalyzerOut(c *VPCConfig) string {
6763
prefix := ""
68-
if c.IsMultipleVPCsConfig {
64+
if c != nil && c.IsMultipleVPCsConfig {
6965
prefix = n.VPC().Name() + Deliminator
7066
}
71-
return prefix + n.NameForAnalyzerOut()
67+
return prefix + n.ResourceName
7268
}
7369

7470
func (n *VPCResource) UID() string {

‎pkg/vpcmodel/explainabilityConnectivity.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ func (c *VPCConfig) getConnectedResource(node Node) (VPCResourceIntf, error) {
394394
func (c *VPCConfig) getContainingConfigNode(node Node) (Node, error) {
395395
nodeIPBlock := node.IPBlock()
396396
if nodeIPBlock == nil { // string cidr does not represent a legal cidr, would be handled earlier
397-
return nil, fmt.Errorf("node %v does not refer to a legal IP", node.NameForAnalyzerOut())
397+
return nil, fmt.Errorf("node %v does not refer to a legal IP", node.NameForAnalyzerOut(nil))
398398
}
399399
for _, configNode := range c.Nodes {
400400
if configNode.IsInternal() {
@@ -441,14 +441,14 @@ func (v *VPCConnectivity) getConnection(c *VPCConfig, src, dst Node) (conn *deta
441441
}
442442
errMsg := "could not find containing config node for %v"
443443
if srcForConnection == nil {
444-
return nil, fmt.Errorf(errMsg, src.NameForAnalyzerOut())
444+
return nil, fmt.Errorf(errMsg, src.NameForAnalyzerOut(nil))
445445
}
446446
dstForConnection, err2 := c.getConnectedResource(dst)
447447
if err2 != nil {
448448
return nil, err2
449449
}
450450
if dstForConnection == nil {
451-
return nil, fmt.Errorf(errMsg, dst.NameForAnalyzerOut())
451+
return nil, fmt.Errorf(errMsg, dst.NameForAnalyzerOut(nil))
452452
}
453453
var ok bool
454454
srcMapValue, ok := v.AllowedConnsCombinedResponsive[srcForConnection]
@@ -457,7 +457,7 @@ func (v *VPCConnectivity) getConnection(c *VPCConfig, src, dst Node) (conn *deta
457457
}
458458
if !ok {
459459
return nil, fmt.Errorf("error: there is a connection between %v and %v, but connection computation failed",
460-
srcForConnection.NameForAnalyzerOut(), dstForConnection.NameForAnalyzerOut())
460+
srcForConnection.NameForAnalyzerOut(nil), dstForConnection.NameForAnalyzerOut(nil))
461461
}
462462
return conn, nil
463463
}

‎pkg/vpcmodel/explainabilityPrint.go

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func endPointInterpretation(c *VPCConfig, userInput string, nodes []Node) string
6464
}
6565
networkInterfaces := make([]string, len(nodes))
6666
for i, node := range nodes {
67-
networkInterfaces[i] = node.ExtendedName(c)
67+
networkInterfaces[i] = node.NameForAnalyzerOut(c)
6868
}
6969
return strings.Join(networkInterfaces, comma)
7070
}
@@ -139,7 +139,7 @@ func (g *groupedConnLine) explainabilityLineStr(c *VPCConfig, connQuery *connect
139139
externalRouter, crossVpcRouter, crossVpcRules := expDetails.externalRouter, expDetails.crossVpcRouter, expDetails.crossVpcRules
140140
privateSubnetRule := g.CommonProperties.expDetails.privateSubnetRule
141141
if externalRouter != nil && isExternal {
142-
externalRouterHeader = "External traffic via " + externalRouter.Kind() + ": " + externalRouter.NameForAnalyzerOut() + newLine
142+
externalRouterHeader = "External traffic via " + externalRouter.Kind() + ": " + externalRouter.NameForAnalyzerOut(nil) + newLine
143143
}
144144
if loadBalancerRule != nil {
145145
loadBalancerHeader = "Load Balancer: " + loadBalancerRule.String(true)
@@ -149,7 +149,7 @@ func (g *groupedConnLine) explainabilityLineStr(c *VPCConfig, connQuery *connect
149149
crossVpcConnection, crossRouterFilterHeader, crossRouterFilterDetails = crossRouterDetails(c, crossVpcRouter,
150150
crossVpcRules, src, dst)
151151
// noConnection is the 1 above when no connectivity
152-
noConnection := noConnectionHeader(src.ExtendedName(c), dst.ExtendedName(c), connQuery) + newLine
152+
noConnection := noConnectionHeader(src.NameForAnalyzerOut(c), dst.NameForAnalyzerOut(c), connQuery) + newLine
153153

154154
// resourceEffectHeader is "2" above
155155
rules := expDetails.rules
@@ -312,15 +312,16 @@ func existingConnectionStr(c *VPCConfig, connQuery *connection.Set, src, dst End
312312
// Computing the header, "1" described in explainabilityLineStr
313313
respondConnStr := respondString(conn)
314314
if connQuery == nil {
315-
resComponents = append(resComponents, fmt.Sprintf("Connections from %v to %v: %v%v\n", src.ExtendedName(c), dst.ExtendedName(c),
315+
resComponents = append(resComponents, fmt.Sprintf("Connections from %v to %v: %v%v\n",
316+
src.NameForAnalyzerOut(c), dst.NameForAnalyzerOut(c),
316317
conn.allConn.String(), respondConnStr))
317318
} else {
318319
properSubsetConn := ""
319320
if !conn.allConn.Equal(connQuery) {
320321
properSubsetConn = "(note that not all queried protocols/ports are allowed)\n"
321322
}
322323
resComponents = append(resComponents, fmt.Sprintf("Connections are allowed from %s to %s%s%s\n%s",
323-
src.ExtendedName(c), dst.ExtendedName(c), connHeader(conn.allConn), respondConnStr, properSubsetConn))
324+
src.NameForAnalyzerOut(c), dst.NameForAnalyzerOut(c), connHeader(conn.allConn), respondConnStr, properSubsetConn))
324325
}
325326
resComponents = append(resComponents, path, details)
326327
return strings.Join(resComponents, newLine)
@@ -423,7 +424,7 @@ func pathStr(allRulesDetails *rulesDetails, filtersRelevant map[string]bool, src
423424
externalRouter, crossVpcRouter RoutingResource, crossVpcConnection *connection.Set,
424425
rules *rulesConnection, privateSubnetRule PrivateSubnetRule) string {
425426
var pathSlice []string
426-
pathSlice = append(pathSlice, "\t"+src.NameForAnalyzerOut())
427+
pathSlice = append(pathSlice, "\t"+src.NameForAnalyzerOut(nil))
427428
if loadBalancerBlocking {
428429
// todo: add loadBalancer as part of the path and also as blocking??? separate PR?
429430
// connection is stopped at the src itself:
@@ -441,15 +442,15 @@ func pathStr(allRulesDetails *rulesDetails, filtersRelevant map[string]bool, src
441442
return blockedPathStr(pathSlice)
442443
}
443444
if isExternal {
444-
externalRouterStr := newLineTab + externalRouter.Kind() + space + externalRouter.NameForAnalyzerOut()
445+
externalRouterStr := newLineTab + externalRouter.Kind() + space + externalRouter.NameForAnalyzerOut(nil)
445446
// externalRouter is fip - add its cidr
446447
if externalRouter.Kind() == fipRouter {
447448
externalRouterStr += space + externalRouter.ExternalIP()
448449
}
449450
pathSlice = append(pathSlice, externalRouterStr)
450451
} else if crossVpcRouterInPath { // src and dst are internal and there is a cross vpc Router
451452
pathSlice = append(pathSlice, newLineTab+src.(InternalNodeIntf).Subnet().VPC().Name(),
452-
crossVpcRouter.Kind()+space+crossVpcRouter.NameForAnalyzerOut())
453+
crossVpcRouter.Kind()+space+crossVpcRouter.NameForAnalyzerOut(nil))
453454
if crossVpcConnection.IsEmpty() { // cross vpc (tgw) denys connection
454455
pathSlice[len(pathSlice)-1] = blockedLeft + pathSlice[len(pathSlice)-1] // blocking cross-vpc router
455456
return blockedPathStr(pathSlice)
@@ -463,9 +464,9 @@ func pathStr(allRulesDetails *rulesDetails, filtersRelevant map[string]bool, src
463464
}
464465
// got here: full path
465466
if len(ingressPath) == 0 {
466-
pathSlice = append(pathSlice, newLineTab+dst.NameForAnalyzerOut())
467+
pathSlice = append(pathSlice, newLineTab+dst.NameForAnalyzerOut(nil))
467468
} else {
468-
pathSlice = append(pathSlice, dst.NameForAnalyzerOut())
469+
pathSlice = append(pathSlice, dst.NameForAnalyzerOut(nil))
469470
}
470471
return strings.Join(pathSlice, arrow)
471472
}

‎pkg/vpcmodel/externalNetwork.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func (exn *ExternalNetwork) Name() string {
6868
return exn.ResourceType + " [" + exn.CidrStr + "]"
6969
}
7070

71-
func (exn *ExternalNetwork) NameForAnalyzerOut() string {
71+
func (exn *ExternalNetwork) NameForAnalyzerOut(c *VPCConfig) string {
7272
return exn.Name()
7373
}
7474

@@ -80,10 +80,6 @@ func (exn *ExternalNetwork) SynthesisKind() spec.ResourceType {
8080
return spec.ResourceTypeExternal
8181
}
8282

83-
func (exn *ExternalNetwork) ExtendedName(c *VPCConfig) string {
84-
return exn.Name()
85-
}
86-
8783
func (exn *ExternalNetwork) IsInternal() bool {
8884
return false
8985
}

0 commit comments

Comments
 (0)