update summery

Author: haim-kermany

pkg/ibmvpc/examples/out/explain_out/LBToResIPNode_all_vpcs_explain_debug.txt

@@ -2,7 +2,7 @@ Explaining connectivity from kube-clusterid:1-8fdd1d0a2ce34deba99d0f885451b1ca t
 =================================================================================================================================================
 
 No connections from from kube-clusterid:1-8fdd1d0a2ce34deba99d0f885451b1ca[LB private IP][192.168.36.6] to iks-clusterid:1[192.168.32.5];
-connection is blocked by Load Balancer
+connection can not be initiated by Load Balancer
 
 Load Balancer: kube-clusterid:1-8fdd1d0a2ce34deba99d0f885451b1ca[LoadBalancer] will not connect to iks-clusterid:1[192.168.32.5], since it is not its pool member
 Egress: security group kube-r006-d7cfb31a-1d4b-40c8-83df-ce2e6f8f2e57 allows connection; network ACL ky-test-edge-acl allows connection

pkg/vpcmodel/explainabilityPrint.go

@@ -204,37 +204,37 @@ func (g *groupedConnLine) explainPerCaseStr(c *VPCConfig, src, dst EndpointElem,
 		return fmt.Sprintf("%v\tThe dst is external but there is no Floating IP or Public Gateway connecting to public internet\n",
 			noConnection)
 	case ingressBlocking || egressBlocking || loadBalancerBlocking:
-		return fmt.Sprintf("%vconnection is blocked %s"+tripleNLVars, noConnection,
-			blockedByString(ingressBlocking, egressBlocking, loadBalancerBlocking),
+		return fmt.Sprintf("%v%s"+tripleNLVars, noConnection,
+			blockSummery(ingressBlocking, egressBlocking, loadBalancerBlocking),
 			headerPlusPath, details)
 	default: // there is a connection
 		return existingConnectionStr(c, connQuery, src, dst, conn, path, details)
 	}
 }
 
-// blockedByString() return the block string according to the flags
-func blockedByString(ingressBlocking, egressBlocking, loadBalancerBlocking bool) string {
+// blockSummery() return a summery of the rules that block the connection, for example:
+// "connection connection is blocked by egress, and can not be initiated by Load Balancer" 
+func blockSummery(ingressBlocking, egressBlocking, loadBalancerBlocking bool) string {
 	blockedBy := []string{}
-	if loadBalancerBlocking {
-		blockedBy = append(blockedBy, "Load Balancer")
-	}
 	if ingressBlocking {
 		blockedBy = append(blockedBy, "ingress")
 	}
 	if egressBlocking {
 		blockedBy = append(blockedBy, "egress")
 	}
 	l := len(blockedBy)
-	var blockedByString string
+	var blockedByString []string
 	switch l {
 	case 1:
-		blockedByString = fmt.Sprintf("by %s", blockedBy[0])
+		blockedByString = append(blockedByString, fmt.Sprintf("is blocked by %s", blockedBy[0]))
 	case 2:
-		blockedByString = fmt.Sprintf("both by %s and %s", blockedBy[0], blockedBy[1])
-	default:
-		blockedByString = fmt.Sprintf("by %s and %s", strings.Join(blockedBy[0:l-1], ", "), blockedBy[l-1])
+		blockedByString = append(blockedByString, fmt.Sprintf("is blocked both by %s and %s", blockedBy[0], blockedBy[1]))
+	}
+
+	if loadBalancerBlocking {
+		blockedByString = append(blockedByString, "can not be initiated by Load Balancer")
 	}
-	return blockedByString
+	return "connection " + strings.Join(blockedByString, ", and ")
 }
 
 func crossRouterDetails(c *VPCConfig, crossVpcRouter RoutingResource, crossVpcRules []RulesInTable,