Skip to content

Commit 538243b

Browse files
committed
Move 2 cases and throw more appropriate exception type
1 parent 3c793f5 commit 538243b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Octokit.Webhooks/Converter/ChangesFieldValueChangeConverter.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,21 @@ public class ChangesFieldValueChangeConverter : JsonConverter<ChangesFieldValueC
1010
var changeObject = JsonSerializer.Deserialize<ChangesFieldValueChange>(ref reader, options);
1111
return changeObject;
1212
case JsonTokenType.String:
13-
case JsonTokenType.True:
14-
case JsonTokenType.False:
1513
return new ChangesFieldValueScalarChange { StringValue = reader.GetString() };
1614
case JsonTokenType.Null:
1715
return null;
1816
case JsonTokenType.Number:
1917
return new ChangesFieldValueScalarChange { NumericValue = reader.GetDecimal() };
2018
case JsonTokenType.None:
19+
case JsonTokenType.True:
20+
case JsonTokenType.False:
2121
case JsonTokenType.EndObject:
2222
case JsonTokenType.StartArray:
2323
case JsonTokenType.EndArray:
2424
case JsonTokenType.PropertyName:
2525
case JsonTokenType.Comment:
2626
default:
27-
throw new InvalidOperationException($"Invalid JsonTokenType {reader.TokenType}");
27+
throw new JsonException($"Invalid JsonTokenType {reader.TokenType}");
2828
}
2929
}
3030

0 commit comments

Comments
 (0)