Skip to content

Commit e642278

Browse files
committed
Fix a bug when li is empty #151
1 parent 112e412 commit e642278

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

src/Html2OpenXml/Expressions/Numbering/ListExpression.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ public override IEnumerable<OpenXmlElement> Interpret(ParsingContext context)
7878
{
7979
var expression = new BlockElementExpression(liNode);
8080
var childElements = expression.Interpret(context);
81+
if (!childElements.Any()) continue;
8182
Paragraph p = (Paragraph) childElements.First();
8283

8384
p.ParagraphProperties ??= new();

test/HtmlToOpenXml.Tests/NumberingTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,16 @@ public void EmptyList_ShouldBeIgnored()
131131
}
132132
}
133133

134+
[Test(Description = "Empty list item should not be registred")]
135+
public void EmptyLiElement_ShouldBeIgnored()
136+
{
137+
var elements = converter.Parse(@"<ul>
138+
<li>not empty</li>
139+
<li></li>
140+
</ul>");
141+
Assert.That(elements, Has.Count.EqualTo(1));
142+
}
143+
134144
[Test(Description = "Increment instanceId based on existing lists")]
135145
public void WithExistingNumbering_ReturnsUniqueInstanceId()
136146
{

0 commit comments

Comments
 (0)