test: Add Node 24 to CI matrix

[PKulkoRaccoonGang]

Description

As a first step in the upgrade to Node 24, add it to the CI matrix as a non-blocking test.

See the tracking issue for further information.

[openedx-webhooks]

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/committers-frontend-build.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (9b2a18f) to head (61880ef).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@      Coverage Diff      @@
##   master   #660   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[itsjeyd]

@PKulkoRaccoonGang Thank you for this contribution!

@openedx/committers-frontend-build It looks like some tests failed to run automatically. Could you please have a look and see if you can enable them?

[UsamaSadiq]

@PKulkoRaccoonGang could you rebase the PR and push again for the tests to be triggered again? The tests seems to be stuck. Pushing the rebased PR will trigger it again. Once the CI is completely green, I'll go ahead and merge the PR.

[UsamaSadiq]

Let's keep the standard of using the .nvmrc file for the base version and add another conditional step in case of Node 24 to use the value from matrix.
In future, when Node 20 support is removed, .nvmrc will be retained as the source of truth as per the decision made by the frontend community some time ago.

We can do conditional setup to maintain nvmrc functionality while adding support to test new version:

# Use .nvmrc if matrix.node == 20
- name: Setup Node.js from .nvmrc
  uses: actions/setup-node@v4
  if: matrix.node == 20
  with:
    node-version-file: '.nvmrc'

# Use matrix.node otherwise
- name: Setup Node.js from matrix
  uses: actions/setup-node@v4
  if: matrix.node != 20
  with:
    node-version: ${{ matrix.node }}

[PKulkoRaccoonGang]

When upgrading Node, we have a series of PRs. The final one, which updates the .nvmrc file, is the single source of truth for the new Node version.

The tracking issue: #657

[UsamaSadiq]

We should keep using the .nvmrc notation for default supported version.

[UsamaSadiq]

@PKulkoRaccoonGang could you rebase the PR and push again for the tests to be triggered again? The tests seems to be stuck. Pushing the rebased PR will trigger it again. Once the CI is completely green, I'll go ahead and merge the PR.

The rebase will not be needed once my review is addressed and a new commit is pushed.

[PKulkoRaccoonGang]

It looks like some tests failed to run automatically. Could you please have a look and see if you can enable them?

I see that the final PR for the Node 24 upgrade has passed all tests. Therefore, I believe we can safely ignore the 'tests' check that is currently stuck on this PR. Please correct me if I'm wrong. I tried restarting the CI checks, but to no avail.

[itsjeyd]

Hey @UsamaSadiq, could you please have a look at @PKulkoRaccoonGang's latest comment above and advise on how to move forward here?

[UsamaSadiq]

Hi @itsjeyd @PKulkoRaccoonGang
The tests check is currently in stuck phase because the CI matrix has been updated but it is marked as required in repository settings.
Even if we merge this PR (we won't be able to do so without admin access), the issue will persist for follow up PRs.

The best way would be to create an axim support ticket to:

• unmark the required check in repo settings for now
• Mark the tests (24) as required

We'll need to repeat this process again once we drop the matrix usage and only proceed with using .nvmrc in the future.

[sarina]

I don't know why I am following this PR but I saw your comment and I'm very confused because when I go into branch protection rules, I can't find the tests (20) or tests (24) checks to make them required. I can disable tests but don't see a way to add in the matrix tests. How would you like to proceed?

[UsamaSadiq]

I don't know why I am following this PR but I saw your comment and I'm very confused because when I go into branch protection rules, I can't find the tests (20) or tests (24) checks to make them required. I can disable tests but don't see a way to add in the matrix tests. How would you like to proceed?

@sarina It's possible that the tests (24) only becomes available in the branch protection rules once this PR is merged and the workflow is updated in the master.
We can proceed with this way:

• Remove the currently required tests check
• Merge this PR
• Mark the new tests (24) check as required

[sarina]

@UsamaSadiq that makes sense! I disabled the check for now, & I'll enable 24 when this merges.

[sarina]

@UsamaSadiq you were right! Enabled (24) now on master.

[openedx-semantic-release-bot]

🎉 This PR is included in version 14.6.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀