Skip to content
This repository was archived by the owner on Jun 14, 2018. It is now read-only.
This repository was archived by the owner on Jun 14, 2018. It is now read-only.

tarball releases do not include version number #16

@daavve

Description

@daavve

Hi,

The version numbers are only generated when you run build inside a git repository:

The makefile gets the version information by running a git command:

${VERSION_FILE}: echo -n "#define INTERNAL_PILLOWFIGHT_VERSION \"" >| $@ echo -n $(shell git describe --always) >> $@ echo "\"" >> $@
Since the tarball does not include the git repository the above command fails and _version.h ends up with the following:

#define INTERNAL_PILLOWFIGHT_VERSION ""
Python then records the version as 0.0.0

I do not know a way to fix this without adding a a duplicate version number to the Makefile. Maybe github provides some hook you can use to automatically include the release number inside the Makefile at release

-Dave

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions