Skip to content

Commit 6d43be5

Browse files
committed
Better test example and confirm test failure
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
1 parent 947c579 commit 6d43be5

File tree

3 files changed

+41
-28
lines changed

3 files changed

+41
-28
lines changed

java-client/src/main/java/org/opensearch/client/json/JsonpUtils.java

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@
4343
import jakarta.json.stream.JsonParser.Event;
4444
import jakarta.json.stream.JsonParsingException;
4545
import java.io.StringReader;
46-
import java.math.BigDecimal;
47-
import java.math.BigInteger;
4846
import java.util.AbstractMap;
4947
import java.util.Map;
5048
import java.util.stream.Collectors;
@@ -80,26 +78,26 @@ public JsonProvider jsonProvider() {
8078
public <T> void serialize(T value, JsonGenerator generator) {
8179
if (value instanceof JsonpSerializable) {
8280
((JsonpSerializable) value).serialize(generator, this);
83-
} else if (value instanceof JsonValue) {
84-
generator.write((JsonValue) value);
85-
} else if (value instanceof String) {
86-
generator.write((String) value);
87-
} else if (value instanceof BigDecimal) {
88-
generator.write((BigDecimal) value);
89-
} else if (value instanceof BigInteger) {
90-
generator.write((BigInteger) value);
91-
} else if (value instanceof Short) {
92-
generator.write((Short) value);
93-
} else if (value instanceof Integer) {
94-
generator.write((Integer) value);
95-
} else if (value instanceof Long) {
96-
generator.write((Long) value);
97-
} else if (value instanceof Float) {
98-
generator.write((Float) value);
99-
} else if (value instanceof Double) {
100-
generator.write((Double) value);
101-
} else if (value instanceof Boolean) {
102-
generator.write((Boolean) value);
81+
// } else if (value instanceof JsonValue) {
82+
// generator.write((JsonValue) value);
83+
// } else if (value instanceof String) {
84+
// generator.write((String) value);
85+
// } else if (value instanceof BigDecimal) {
86+
// generator.write((BigDecimal) value);
87+
// } else if (value instanceof BigInteger) {
88+
// generator.write((BigInteger) value);
89+
// } else if (value instanceof Short) {
90+
// generator.write((Short) value);
91+
// } else if (value instanceof Integer) {
92+
// generator.write((Integer) value);
93+
// } else if (value instanceof Long) {
94+
// generator.write((Long) value);
95+
// } else if (value instanceof Float) {
96+
// generator.write((Float) value);
97+
// } else if (value instanceof Double) {
98+
// generator.write((Double) value);
99+
// } else if (value instanceof Boolean) {
100+
// generator.write((Boolean) value);
103101
} else {
104102
throw new JsonException(
105103
"Cannot find a serializer for type " + value.getClass().getName() + ". Consider using a full-featured JsonpMapper."
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
/*
2+
* SPDX-License-Identifier: Apache-2.0
3+
*
4+
* The OpenSearch Contributors require contributions made to
5+
* this file be licensed under the Apache-2.0 license or a
6+
* compatible open source license.
7+
*/
8+
9+
package org.opensearch.client.opensearch._types.aggregations;
10+
11+
import org.junit.Test;
12+
import org.opensearch.client.opensearch.model.ModelTestCase;
13+
14+
public class ExtendedBoundsTest extends ModelTestCase {
15+
@Test
16+
public void testToJsonString() {
17+
ExtendedBounds<Double> bounds = ExtendedBounds.of(eb -> eb.min(0.0).max(4096.0));
18+
19+
assertEquals("{\"max\":4096.0,\"min\":0.0}", bounds.toJsonString());
20+
}
21+
}

java-client/src/test/java/org/opensearch/client/opensearch/core/IndexRequestTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,4 @@ static class MyDoc {
2828
this.key = key;
2929
}
3030
}
31-
32-
@Test
33-
public void indexRequestToJson() {
34-
IndexRequest<Object> indexRequest = IndexRequest.of(i -> i.index("index").document("document"));
35-
assertNotNull(indexRequest.toJsonString());
36-
}
3731
}

0 commit comments

Comments
 (0)