Merge pull request #732 from openstudiocoalition/fix_cpack

Fix a race condition during CPack packaging when creating symlink on Apple

Author: jmarrec

src/openstudio_app/CMakeLists.txt

@@ -472,6 +472,13 @@ if( APPLE )
           "${CMAKE_INSTALL_PREFIX}/OpenStudioApp.app/Contents/Frameworks/$<TARGET_FILE_NAME:openstudio::openstudiolib>"
 
         COMMAND "${CMAKE_COMMAND}" -E make_directory "${CMAKE_INSTALL_PREFIX}/bin"
+
+        COMMAND_ECHO STDOUT
+        COMMAND_ERROR_IS_FATAL ANY
+      )
+
+      # We break it into two `execute_process`es so that there is no race condition between the make_directory above and the create_symlink below
+      execute_process(
         COMMAND "${CMAKE_COMMAND}" -E create_symlink
           "../OpenStudioApp.app/Contents/MacOS/$<TARGET_FILE_NAME:openstudio::openstudio>"
           "${CMAKE_INSTALL_PREFIX}/bin/$<TARGET_FILE_NAME:openstudio::openstudio>"