clang format + cppcheck

Author: jmarrec

src/openstudio_lib/LocationTabView.cpp

@@ -638,7 +638,8 @@ std::string toLowerCase(const std::string& str) {
   return lowerStr;
 }
 
-std::vector<model::DesignDay> filterDesignDays(const std::vector<model::DesignDay>& designDays, const std::string& dayType, const std::string& percentage, const std::string& humidityConditionType = "") {
+std::vector<model::DesignDay> filterDesignDays(const std::vector<model::DesignDay>& designDays, const std::string& dayType,
+                                               const std::string& percentage, const std::string& humidityConditionType = "") {
   std::vector<model::DesignDay> filteredDesignDays;
 
   std::copy_if(designDays.begin(), designDays.end(), std::back_inserter(filteredDesignDays), [&](const model::DesignDay& designDay) {
@@ -648,9 +649,10 @@ std::vector<model::DesignDay> filterDesignDays(const std::vector<model::DesignDa
       return false;
     }
 
-    bool matchesHumidityConditionType = humidityConditionType.empty() || toLowerCase(designDay.humidityConditionType()) == toLowerCase(humidityConditionType);
-    bool matchesPercentage = QString::fromStdString(name.get()).contains(QString::fromStdString(percentage)) ||
-                             (percentage == "0.4%" && QString::fromStdString(name.get()).contains(".4%"));
+    bool matchesHumidityConditionType =
+      humidityConditionType.empty() || toLowerCase(designDay.humidityConditionType()) == toLowerCase(humidityConditionType);
+    bool matchesPercentage = QString::fromStdString(name.get()).contains(QString::fromStdString(percentage))
+                             || (percentage == "0.4%" && QString::fromStdString(name.get()).contains(".4%"));
     return name && matchesPercentage && toLowerCase(designDay.dayType()) == toLowerCase(dayType) && matchesHumidityConditionType;
   });
 
@@ -663,17 +665,17 @@ std::vector<model::DesignDay> LocationView::showDesignDaySelectionDialog(const s
   QDialog dialog(this);
   dialog.setWindowTitle(QCoreApplication::translate("LocationView", "Import Design Days"));
 
-  QGridLayout *layout = new QGridLayout(&dialog);
+  QGridLayout* layout = new QGridLayout(&dialog);
 
   // Define row labels and percentages
   QStringList rowLabels = {"Heating", "Cooling"};
   std::vector<std::string> heatingPercentages = {"99.6%", "99%"};
   std::vector<std::string> coolingPercentages = {"2%", "1%", "0.4%"};
 
   // Ok and Cancel buttons
-  QPushButton *okButton = new QPushButton(tr("Ok"), &dialog);
-  QPushButton *cancelButton = new QPushButton(tr("Cancel"), &dialog);
-  QPushButton *importAllButton = new QPushButton(tr("Skip\nselection\nimport\nall DDYs"), &dialog);
+  QPushButton* okButton = new QPushButton(tr("Ok"), &dialog);
+  QPushButton* cancelButton = new QPushButton(tr("Cancel"), &dialog);
+  QPushButton* importAllButton = new QPushButton(tr("Skip\nselection\nimport\nall DDYs"), &dialog);
 
   // Set the same size for all buttons
   okButton->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Preferred);
@@ -688,7 +690,7 @@ std::vector<model::DesignDay> LocationView::showDesignDaySelectionDialog(const s
   okButton->setMinimumSize(cancelButton->sizeHint());
   importAllButton->setMinimumSize(cancelButton->sizeHint());
 
-  okButton->setEnabled(false); // Initially disable the Ok button
+  okButton->setEnabled(false);  // Initially disable the Ok button
 
   connect(okButton, &QPushButton::clicked, &dialog, &QDialog::accept);
   connect(cancelButton, &QPushButton::clicked, &dialog, &QDialog::reject);
@@ -699,16 +701,16 @@ std::vector<model::DesignDay> LocationView::showDesignDaySelectionDialog(const s
 
   // Populate table for Heating and Cooling
   for (int row = 0; row < rowLabels.size(); ++row) {
-    QLabel *rowLabel = new QLabel(rowLabels[row]);
+    QLabel* rowLabel = new QLabel(rowLabels[row]);
     layout->addWidget(rowLabel, row * 2 + 1, 0, Qt::AlignCenter);
 
     const auto& percentages = (row == 0) ? heatingPercentages : coolingPercentages;
 
     for (int col = 0; col < percentages.size(); ++col) {
-      QLabel *percentageLabel = new QLabel(QString::fromStdString(percentages[col]));
+      QLabel* percentageLabel = new QLabel(QString::fromStdString(percentages[col]));
       layout->addWidget(percentageLabel, row * 2, col + 1, Qt::AlignCenter);
 
-      QCheckBox *checkBox = new QCheckBox();
+      QCheckBox* checkBox = new QCheckBox();
       layout->addWidget(checkBox, row * 2 + 1, col + 1, Qt::AlignCenter);
 
       connect(checkBox, &QCheckBox::toggled, [=, &designDaysToInsert](bool checked) {
@@ -733,7 +735,7 @@ std::vector<model::DesignDay> LocationView::showDesignDaySelectionDialog(const s
   }
 
   // Add a spacer item to add more space between the checkboxes and the buttons
-  QSpacerItem *spacer = new QSpacerItem(20, 40, QSizePolicy::Minimum, QSizePolicy::Expanding);
+  QSpacerItem* spacer = new QSpacerItem(20, 40, QSizePolicy::Minimum, QSizePolicy::Expanding);
   layout->addItem(spacer, rowLabels.size() * 2 + 2, 0, 1, 5);
 
   dialog.setLayout(layout);
@@ -749,7 +751,6 @@ std::vector<model::DesignDay> LocationView::showDesignDaySelectionDialog(const s
 
 void LocationView::onDesignDayBtnClicked() {
   QString fileTypes("Files (*.ddy)");
-  std::vector<openstudio::model::DesignDay> designDaysToInsert;
 
   QString lastPath = m_lastDdyPathOpened;
   if (lastPath.isEmpty() && m_lastEpwPathOpened.isEmpty()) {
@@ -767,12 +768,12 @@ void LocationView::onDesignDayBtnClicked() {
     if (ddyIdfFile) {
 
       openstudio::Workspace ddyWorkspace(StrictnessLevel::None, IddFileType::EnergyPlus);
-  
+
       for (const IdfObject& idfObject : ddyIdfFile->objects()) {
         IddObjectType iddObjectType = idfObject.iddObject().type();
-        if ((iddObjectType == IddObjectType::SizingPeriod_DesignDay) || (iddObjectType == IddObjectType::SizingPeriod_WeatherFileDays) 
+        if ((iddObjectType == IddObjectType::SizingPeriod_DesignDay) || (iddObjectType == IddObjectType::SizingPeriod_WeatherFileDays)
             || (iddObjectType == IddObjectType::SizingPeriod_WeatherFileConditionType)) {
-              ddyWorkspace.addObject(idfObject);
+          ddyWorkspace.addObject(idfObject);
         }
       }
 
@@ -782,7 +783,6 @@ void LocationView::onDesignDayBtnClicked() {
       // Use a heuristic based on the ddy files provided by EnergyPlus
       // Filter out the days that are not helpful.
       if (!ddyModel.objects().empty()) {
- 
 
         // Evan note: do not remove existing design days
         //for (model::SizingPeriod sizingPeriod : m_model.getModelObjects<model::SizingPeriod>()){

src/openstudio_lib/LocationTabView.hpp

@@ -124,7 +124,8 @@ class LocationView : public QWidget
 
   void onWeatherFileBtnClicked();
 
-  std::vector<openstudio::model::DesignDay> showDesignDaySelectionDialog(const std::vector<openstudio::model::DesignDay, std::allocator<openstudio::model::DesignDay>>& allNonAnnual);
+  std::vector<openstudio::model::DesignDay>
+    showDesignDaySelectionDialog(const std::vector<openstudio::model::DesignDay, std::allocator<openstudio::model::DesignDay>>& allNonAnnual);
 
   void onDesignDayBtnClicked();