use non permanent key in ad-hoc issuance flow (#178)

* use non permanent key in ad-hoc issuance flow

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* slight refactoring

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

---------

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

Author: JoTiTu

src/WalletFramework.Oid4Vc/Oid4Vci/CredRequest/Implementations/CredentialRequestService.cs

@@ -57,25 +57,26 @@ private async Task<CredentialRequest> CreateCredentialRequest(
             oauthToken => oauthToken.CNonce,
             dPopToken => dPopToken.Token.CNonce);
 
-        var keyBindingJwt = await _sdJwtSigner.GenerateKbProofOfPossessionAsync(
-            keyId,
-            issuerMetadata.CredentialIssuer.ToString(),
-            cNonce,
-            "openid4vci-proof+jwt",
-            null,
-            clientOptions.ToNullable()?.ClientId);
-        
         var proof = Option<ProofOfPossession>.None;
         var sessionTranscript = Option<SessionTranscript>.None;
 
-        authorizationRequest.Match(
+        await authorizationRequest.Match(
             Some: _ =>
             {
                 if (format == "mso_mdoc")
                     sessionTranscript = authorizationRequest.UnwrapOrThrow(new Exception()).ToVpHandover().ToSessionTranscript();
+                return Task.CompletedTask;
             },
-            None: () =>
+            None: async () =>
             {
+                var keyBindingJwt = await _sdJwtSigner.GenerateKbProofOfPossessionAsync(
+                    keyId,
+                    issuerMetadata.CredentialIssuer.ToString(),
+                    cNonce,
+                    "openid4vci-proof+jwt",
+                    null,
+                    clientOptions.ToNullable()?.ClientId);
+                
                 proof = new ProofOfPossession
                 {
                     ProofType = "jwt",
@@ -93,7 +94,7 @@ async Task<Validation<CredentialResponse>> ICredentialRequestService.RequestCred
         Option<ClientOptions> clientOptions,
         Option<AuthorizationRequest> authorizationRequest)
     {
-        var keyId = await _keyStore.GenerateKey();
+        var keyId = await _keyStore.GenerateKey(isPermanent: authorizationRequest.IsNone);
 
         var requestJson = await configuration.Match(
             async sdJwt =>