adjust txdata error (#310)

Signed-off-by: Kevin <kevin.dinh@lissi.id>

Author: Dindexx

src/WalletFramework.Oid4Vc/Oid4Vp/Services/Oid4VpClientService.cs

@@ -355,7 +355,7 @@ from claim in sdJwtRecord.Claims
             ClientId = authorizationRequest.ClientId,
             ClientMetadata = authorizationRequest.ClientMetadata,
             Name = authorizationRequest.Requirements.Match(
-                dcqlQuery => Option<string>.None,
+                _ => Option<string>.None,
                 presentationDefinition => presentationDefinition.Name),
             PresentedCredentialSets = presentedCredentials.ToList()
         };
@@ -637,7 +637,7 @@ from claim in sdJwtRecord.Claims
             ClientId = authorizationRequest.ClientId,
             ClientMetadata = authorizationRequest.ClientMetadata,
             Name = authorizationRequest.Requirements.Match(
-                dcqlQuery => Option<string>.None,
+                _ => Option<string>.None,
                 presentationDefinition => presentationDefinition.Name),
             PresentedCredentialSets = presentedCredentials.ToList()
         };
@@ -675,7 +675,7 @@ public async Task<Validation<AuthorizationRequestCancellation, PresentationCandi
             var uc5TxDataOption = presentationCandidates
                 .AuthorizationRequest
                 .Requirements.Match(
-                    dcqlQuery => Option<IEnumerable<InputDescriptorTransactionData>>.None,
+                    _ => Option<IEnumerable<InputDescriptorTransactionData>>.None,
                     presentationDefinition => presentationDefinition.InputDescriptors.TraverseAny(descriptor =>
                         descriptor.TransactionData.OnSome(list =>
                             new InputDescriptorTransactionData(descriptor.Id, list))));
@@ -713,7 +713,8 @@ private static Validation<AuthorizationRequestCancellation, PresentationCandidat
                     return candidates.FindCandidateForTransactionData(transactionData).Match(
                         candidate => candidate.AddTransactionData(transactionData),
                         () => (Validation<PresentationCandidate>)new InvalidTransactionDataError(
-                            $"No credentials found that satisfy the transaction data with type {transactionData.GetTransactionDataType().AsString()}"));
+                            $"No credentials found that satisfy the transaction data with type {transactionData.GetTransactionDataType().AsString()}",
+                            presentationCandidates));
                 });
 
                 return candidatesValidation.OnSuccess(enumerable => presentationCandidates with
@@ -722,7 +723,8 @@ private static Validation<AuthorizationRequestCancellation, PresentationCandidat
                 });
             },
             () => new InvalidTransactionDataError(
-                    "No credentials found that satisfy the authorization request with transaction data")
+                    "No credentials found that satisfy the authorization request with transaction data",
+                    presentationCandidates)
                 .ToInvalid<PresentationCandidates>()
         );
 
@@ -748,7 +750,9 @@ private static Validation<AuthorizationRequestCancellation, PresentationCandidat
 
                     return candidateOption.Match(
                         candidate => candidate.AddUc5TransactionData(inputDescriptorTxData.TransactionData),
-                        () => (Validation<PresentationCandidate>)new InvalidTransactionDataError("No credentials found that satisfy the authorization request with transaction data") 
+                        () => (Validation<PresentationCandidate>)new InvalidTransactionDataError(
+                            "No credentials found that satisfy the authorization request with transaction data",
+                            presentationCandidates) 
                     );
                 });
 

src/WalletFramework.Oid4Vc/Oid4Vp/TransactionDatas/Errors/InvalidTransactionDataError.cs

@@ -1,12 +1,15 @@
 using LanguageExt;
 using WalletFramework.Oid4Vc.Oid4Vp.Errors;
+using WalletFramework.Oid4Vc.Oid4Vp.Models;
 
 namespace WalletFramework.Oid4Vc.Oid4Vp.TransactionDatas.Errors;
 
 public record InvalidTransactionDataError : VpError
 {
     private const string Code = "invalid_transaction_data";
-    
+
+    public Option<PresentationCandidates> PresentationCandidates { get; }
+
     public InvalidTransactionDataError(string message) : base(Code, message)
     {
     }
@@ -16,4 +19,13 @@ public InvalidTransactionDataError(
         Option<Exception> Exception) : base(Code, Message, Exception)
     {
     }
+
+    public InvalidTransactionDataError(string message, PresentationCandidates candidates) : base(Code, message) =>
+        PresentationCandidates = candidates;
+
+    public InvalidTransactionDataError(
+        string Message,
+        PresentationCandidates candidates,
+        Option<Exception> Exception) : base(Code, Message, Exception) =>
+        PresentationCandidates = candidates;
 }