improve transaction data processing

Signed-off-by: kenkosmowski <ken.kosmowski@gmx.de>

Author: kenkosmowski

src/WalletFramework.Oid4Vc/Oid4Vp/Models/PresentationCandidate.cs

@@ -49,17 +49,13 @@ public PresentationCandidate(
 
 public static class PresentationCandidateFun
 {
-    public static PresentationCandidate AddTransactionData(
+    public static PresentationCandidate AddTransactionDatas(
         this PresentationCandidate candidate,
-        TransactionData transactionData)
+        IEnumerable<TransactionData> transactionDatas)
     {
-        var td = candidate.TransactionData.Match(
-            list => list.Append(transactionData),
-            () => [transactionData]);
-
         return candidate with
         {
-            TransactionData = td.ToList()
+            TransactionData = transactionDatas.ToList()
         };
     }
 

src/WalletFramework.Oid4Vc/Oid4Vp/Services/Oid4VpClientService.cs

@@ -709,24 +709,28 @@ public async Task<Validation<AuthorizationRequestCancellation, PresentationReque
 
     private static Validation<AuthorizationRequestCancellation, PresentationRequest> ProcessVpTransactionData(
         PresentationRequest presentationRequest,
-        IEnumerable<TransactionData> transactionDatas)
+        IEnumerable<TransactionData> vpTransactionDatas)
     {
         var result = presentationRequest.Candidates.Match(
             candidates =>
             {
-                var candidatesValidation = transactionDatas.TraverseAll(transactionData =>
+                var transactionDatas = vpTransactionDatas.ToList();
+                candidates = candidates.Select(candidate =>
                 {
-                    return candidates.FindCandidateForTransactionData(transactionData).Match(
-                        candidate => candidate.AddTransactionData(transactionData),
-                        () => (Validation<PresentationCandidate>)new InvalidTransactionDataError(
-                            $"No credentials found that satisfy the transaction data with type {transactionData.GetTransactionDataType().AsString()}",
-                            presentationRequest));
-                });
-        
-                return candidatesValidation.OnSuccess(enumerable => presentationRequest with
-                {
-                    Candidates = enumerable.ToList()
-                });
+                    return candidate.AddTransactionDatas(transactionDatas.Where(transactionData => transactionData
+                        .GetCredentialIds().Select(id => id.AsString)
+                        .Contains(candidate.Identifier)));
+                }).ToList();
+
+                var satisfiedTransactionDatas = candidates.Where(x => x.TransactionData.IsSome)
+                    .SelectMany(x => x.TransactionData.UnwrapOrThrow());
+                if (transactionDatas.Any(transactionData => !satisfiedTransactionDatas.Contains(transactionData)))
+                    return new InvalidTransactionDataError(
+                            "Not enough credentials found to satisfy the authorization request with transaction data",
+                            presentationRequest)
+                        .ToInvalid<PresentationRequest>();
+                
+                return presentationRequest with { Candidates = candidates };
             },
             () => new InvalidTransactionDataError(
                     "No credentials found that satisfy the authorization request with transaction data",

src/WalletFramework.Oid4Vc/Oid4Vp/TransactionDatas/TransactionData.cs

@@ -52,12 +52,9 @@ public static IEnumerable<TransactionDataHashesAlg> GetHashesAlg(this Transactio
 
     public static Base64UrlString GetEncoded(this TransactionData transactionData) =>
         transactionData.GetTransactionDataProperties().Encoded;
-
-    public static Option<PresentationCandidate> FindCandidateForTransactionData(
-        this IEnumerable<PresentationCandidate> candidates,
-        TransactionData transactionData) => candidates.FirstOrDefault(candidate =>
-        transactionData.GetTransactionDataProperties().CredentialIds.Select(id => id.AsString)
-            .Contains(candidate.Identifier));
+    
+    public static IEnumerable<TransactionDataCredentialId> GetCredentialIds(this TransactionData transactionData) =>
+        transactionData.GetTransactionDataProperties().CredentialIds;
 
     private static TransactionDataProperties GetTransactionDataProperties(this TransactionData transactionData) =>
         transactionData.Match(