Skip to content

Commit c6ec1bd

Browse files
committed
added some notes
1 parent e1c353a commit c6ec1bd

File tree

9 files changed

+26
-17
lines changed

9 files changed

+26
-17
lines changed

.idea/caches/build_file_checksums.ser

0 Bytes
Binary file not shown.

.idea/caches/gradle_models.ser

196 KB
Binary file not shown.

.idea/gradle.xml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/inspectionProfiles/Project_Default.xml

Lines changed: 0 additions & 8 deletions
This file was deleted.

.idea/misc.xml

Lines changed: 13 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ buildscript {
77
jcenter()
88
}
99
dependencies {
10-
classpath 'com.android.tools.build:gradle:3.1.3'
10+
classpath 'com.android.tools.build:gradle:3.3.1'
1111

1212

1313
// NOTE: Do not place your application dependencies here; they belong

easysettings-basic/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ android {
2121
}
2222

2323
dependencies {
24-
implementation 'com.android.support:support-annotations:27.1.0'
24+
implementation 'com.android.support:support-annotations:28.0.0'
2525
api 'org.greenrobot:eventbus:3.1.1'
2626
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Wed Mar 28 09:57:51 IDT 2018
1+
#Sat Mar 02 14:40:08 IST 2019
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip

sample/src/main/java/or_dvir/hotmail/com/ActivityMain.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@
1919

2020
public class ActivityMain extends AppCompatActivity
2121
{
22+
23+
//todo next version try to remove dependencies from other libraries!!!
24+
//todo but if you still need the dependency, change BOTH LIBRARY MODULS gradle file
25+
//todo from "Api" to either "implementation" or "compileOnly"
26+
2227
private static final int REQUEST_CODE_ACTIVITY_SETTINGS = 1001;
2328

2429
public static final String EXTRA_SETTINGS_LIST = "EXTRA_SETTINGS_LIST";
@@ -80,10 +85,9 @@ protected void onCreate(Bundle savedInstanceState)
8085
.build(),
8186
new BasicSettingsObject.Builder(SETTINGS_KEY_BASIC, "fancy title 1")
8287
.setSummary("fancy summary")
83-
.setIcon(null)
8488
//todo NOTE:
8589
//todo because of the way this sample app is written,
86-
//todo this method will throw a "NotSerializableException".
90+
//todo this method will throw a NotSerializableException.
8791
//todo however, this method will work if the settings are managed in a way
8892
//todo which does not require serialization
8993
// .setIconDrawable(getResources().getDrawable(R.drawable.ic_launcher_round))

0 commit comments

Comments
 (0)