Fix potential bug with StatefulSet controller when reconciling deletion

thegridman · thegridman · commit fef45ec95862 · 2020-07-16T15:10:17.000+03:00
diff --git a/pkg/controller/statefulset/statefulset_controller.go b/pkg/controller/statefulset/statefulset_controller.go
@@ -115,7 +115,7 @@ func (in *ReconcileStatefulSet) ReconcileResources(request reconcile.Request, de
 
 	if stsExists && stsCurrent.GetDeletionTimestamp() != nil {
 		// The StatefulSet exists but is being deleted
-		stsExists = false
+		return result, nil
 	}
 
 	switch {

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ func (in *ReconcileStatefulSet) ReconcileResources(request reconcile.Request, de`
`115`	`115`
`116`	`116`	`if stsExists && stsCurrent.GetDeletionTimestamp() != nil {`
`117`	`117`	`// The StatefulSet exists but is being deleted`
`118`		`- stsExists = false`
	`118`	`+ return result, nil`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`switch {`