Why do we adopt array alignment?

[mohamedsabil83]

I was asking myself this question a while ago? Why do we adopt array alignment even though Laravel does not?

[luisprmat]

Are you referring to this?

[mohamedsabil83]

Yes, I do. It's matching how Laravel did. Also, if we adding a new long phrase in the future, we don't need to re-align all the lines.

[luisprmat]

I agree with you, it's better like in Laravel. Imagine that we also align the JSON, it would look awful!!!

{
    ...
    "This user already belongs to the team.": "Este usuario ya pertenece al equipo.",
    "to":                                     "al",
    "Toggle navigation":                      "Activar navegación",
    "Token Name":                             "Nombre del token",
    ...
}

I vote to change the alignment we have and use Laravel's, and also to be consistent.
@caouecs, @masterix21, @WhereIsLucas, @jorgercosta, @andrey-helldar, @LukaLatkovic, @MrAlKuz, @overtrue, @jensstigaard, and team, what do you think about this?

[andrey-helldar]

Yes, I do. It's matching how Laravel did. Also, if we adding a new long phrase in the future, we don't need to re-align all the lines.

Formatting lines is done by pressing three buttons on the keyboard - Ctrl+Alt+L (phpStorm)

[andrey-helldar]

I agree with you, it's better like in Laravel. Imagine that we also align the JSON, it would look awful!!!

Therefore, we do not touch JSON.

I vote to change the alignment we have and use Laravel's, and also to be consistent.

I am for beautiful code. Without alignment, the code is hard to read. It seems that such code is written by those who did not study well at school.

See:

versus

As I've said many times, what Taylor does is good, but far from ideal.

[andrey-helldar]

@luisprmat, @mohamedsabil83, there is another way to solve problem - to use a translation manager. For example, this one. (@caouecs, for example 😀 ).

In his settings, you can set the alignment option. If it is not needed, set 'alignment' => false and the files will be saved in Laravel-way.

[andrey-helldar]

Because Taylor doesn't care what the code looks like - good or bad.

We prefer pretty code and therefore we apply alignment in php files.

[mohamedsabil83]

Formatting lines is done by pressing three buttons on the keyboard - Ctrl+Alt+L (phpStorm)

Yes, that's what I do.

Because Taylor doesn't care what the code looks like - good or bad.

We prefer pretty code and therefore we apply alignment in php files.

As I guess. Just to know if there is another reason. I'll keep the package aligned and ignore alignment on my projects

[andrey-helldar]

No, there is no other reason. Only the visual beauty of the code. 😊

[masterix21]

I agree with @andrey-helldar because we must do everything to simplify our work, keep a clean code, and maintainable.